From 6fd86f7d3da58c8b1907e174fd75f2b7e66a2a6a Mon Sep 17 00:00:00 2001 From: timgl Date: Tue, 18 Jun 2024 13:57:52 +0100 Subject: [PATCH] =?UTF-8?q?perf:=20Use=20max=5Fbytes=5Fbefore=5Fexternal?= =?UTF-8?q?=5Fgroup=5Fby=20for=20funnels=20and=20path=20que=E2=80=A6=20(#2?= =?UTF-8?q?3022)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * perf: Use max_bytes_before_external_group_by for funnels and path queries * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * fix test * also do retention query * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> --- .../api/test/__snapshots__/test_query.ambr | 96 +++-- .../__snapshots__/test_execute_async.ambr | 3 +- .../test/__snapshots__/test_heatmaps_api.ambr | 90 +++-- posthog/hogql/constants.py | 3 + .../test_session_replay_events.ambr | 42 ++- posthog/hogql/database/test/test_database.py | 2 +- .../test/__snapshots__/test_cohort.ambr | 6 +- .../hogql/functions/test/test_sparkline.py | 2 +- .../hogql/test/__snapshots__/test_query.ambr | 72 ++-- posthog/hogql/test/test_printer.py | 28 +- posthog/hogql/test/test_query.py | 4 +- .../test/__snapshots__/test_in_cohort.ambr | 12 +- .../insights/funnels/funnels_query_runner.py | 4 + .../test/__snapshots__/test_funnel.ambr | 48 ++- ...test_funnel_breakdowns_by_current_url.ambr | 6 +- .../test_funnel_correlation.ambr | 201 +++++++---- .../test_funnel_correlations_persons.ambr | 30 +- .../__snapshots__/test_funnel_persons.ambr | 18 +- .../__snapshots__/test_funnel_strict.ambr | 18 +- .../test_funnel_strict_persons.ambr | 18 +- .../test_funnel_time_to_convert.ambr | 9 +- .../__snapshots__/test_funnel_trends.ambr | 9 +- .../test_funnel_trends_persons.ambr | 18 +- .../__snapshots__/test_funnel_unordered.ambr | 18 +- .../test_funnel_unordered_persons.ambr | 3 +- .../insights/paths_query_runner.py | 4 + .../insights/retention_query_runner.py | 2 + .../test_lifecycle_query_runner.ambr | 12 +- .../test_paths_query_runner_ee.ambr | 165 ++++++--- .../test_retention_query_runner.ambr | 42 ++- .../test/__snapshots__/test_trends.ambr | 333 ++++++++++++------ .../test_trends_data_warehouse_query.ambr | 15 +- .../test_sessions_timeline_query_runner.ambr | 21 +- ...t_session_recording_list_from_filters.ambr | 318 +++++++++++------ 34 files changed, 1098 insertions(+), 574 deletions(-) diff --git a/posthog/api/test/__snapshots__/test_query.ambr b/posthog/api/test/__snapshots__/test_query.ambr index 495d39c4540b7..0b0ecf5fd221a 100644 --- a/posthog/api/test/__snapshots__/test_query.ambr +++ b/posthog/api/test/__snapshots__/test_query.ambr @@ -17,7 +17,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_event_property_filter.1 @@ -38,7 +39,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_event_property_filter.2 @@ -59,7 +61,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_event_property_filter_materialized @@ -80,7 +83,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_event_property_filter_materialized.1 @@ -101,7 +105,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_event_property_filter_materialized.2 @@ -122,7 +127,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_events_query_all_time_date @@ -139,7 +145,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_events_query_all_time_date.1 @@ -156,7 +163,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_events_query_all_time_date.2 @@ -173,7 +181,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_full_hogql_query @@ -192,7 +201,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_full_hogql_query_async @@ -236,7 +246,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_full_hogql_query_view @@ -255,7 +266,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_full_hogql_query_view.1 @@ -278,7 +290,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter @@ -299,7 +312,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter.1 @@ -320,7 +334,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter.2 @@ -341,7 +356,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter.3 @@ -362,7 +378,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter_materialized @@ -383,7 +400,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter_materialized.1 @@ -404,7 +422,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter_materialized.2 @@ -425,7 +444,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_hogql_property_filter_materialized.3 @@ -446,7 +466,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_person_property_filter @@ -485,7 +506,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_person_property_filter_materialized @@ -524,7 +546,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_property_filter_aggregations @@ -543,7 +566,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_property_filter_aggregations.1 @@ -563,7 +587,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_property_filter_aggregations_materialized @@ -582,7 +607,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_property_filter_aggregations_materialized.1 @@ -602,7 +628,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_select_event_person @@ -621,7 +648,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_select_hogql_expressions @@ -641,7 +669,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_select_hogql_expressions.1 @@ -659,7 +688,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_select_hogql_expressions.2 @@ -678,7 +708,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestQuery.test_select_hogql_expressions.3 @@ -697,6 +728,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/clickhouse/client/test/__snapshots__/test_execute_async.ambr b/posthog/clickhouse/client/test/__snapshots__/test_execute_async.ambr index da448adc72d97..757bd9e1afb85 100644 --- a/posthog/clickhouse/client/test/__snapshots__/test_execute_async.ambr +++ b/posthog/clickhouse/client/test/__snapshots__/test_execute_async.ambr @@ -9,6 +9,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/heatmaps/test/__snapshots__/test_heatmaps_api.ambr b/posthog/heatmaps/test/__snapshots__/test_heatmaps_api.ambr index 80c65bf353588..0fcd4a875e4c8 100644 --- a/posthog/heatmaps/test/__snapshots__/test_heatmaps_api.ambr +++ b/posthog/heatmaps/test/__snapshots__/test_heatmaps_api.ambr @@ -22,7 +22,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_exact_url.1 @@ -48,7 +49,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com* @@ -74,7 +76,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com*.1 @@ -100,7 +103,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products* @@ -126,7 +130,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products*.1 @@ -152,7 +157,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/*/parts/* @@ -178,7 +184,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/*/parts/*.1 @@ -204,7 +211,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/*/reviews/* @@ -230,7 +238,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/*/reviews/*.1 @@ -256,7 +265,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/1* @@ -282,7 +292,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/1*.1 @@ -308,7 +319,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/1*/parts/* @@ -334,7 +346,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_http://example.com/products/1*/parts/*.1 @@ -360,7 +373,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_url_pattern_where_end_is_anchored @@ -386,7 +400,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_viewport_0_min_150 @@ -412,7 +427,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_viewport_1_min_161 @@ -438,7 +454,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_viewport_2_min_177 @@ -464,7 +481,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_viewport_3_min_201 @@ -490,7 +508,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_filter_by_viewport_4_min_161_and_max_192 @@ -516,7 +535,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_all_data_response @@ -542,7 +562,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_count_by_aggregation @@ -568,7 +589,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_count_by_aggregation.1 @@ -594,7 +616,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_empty_response @@ -620,7 +643,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_filter_by_click @@ -646,7 +670,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_filter_by_click.1 @@ -672,7 +697,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_filter_by_date_from @@ -698,7 +724,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_filter_by_relative_date @@ -724,7 +751,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_filter_by_relative_date.1 @@ -750,7 +778,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordings.test_can_get_scrolldepth_counts @@ -776,6 +805,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql/constants.py b/posthog/hogql/constants.py index f1f20ff45f484..769d4a250e65e 100644 --- a/posthog/hogql/constants.py +++ b/posthog/hogql/constants.py @@ -36,6 +36,8 @@ MAX_SELECT_HEATMAPS_LIMIT = 1000000 # 1m datapoints # Max limit for all cohort calculations MAX_SELECT_COHORT_CALCULATION_LIMIT = 1000000000 # 1b persons +# Max amount of memory usage when doing group by before swapping to disk. Only used in certain queries +MAX_BYTES_BEFORE_EXTERNAL_GROUP_BY = 22 * 1024 * 1024 * 1024 CSV_EXPORT_LIMIT = MAX_SELECT_RETURNED_ROWS CSV_EXPORT_BREAKDOWN_LIMIT_INITIAL = 512 @@ -102,3 +104,4 @@ class HogQLGlobalSettings(HogQLQuerySettings): max_ast_elements: Optional[int] = 50000 * 20 # default value 50000 max_expanded_ast_elements: Optional[int] = 1000000 max_query_size: Optional[int] = 262144 * 2 # default value 262144 (= 256 KiB) + max_bytes_before_external_group_by: Optional[int] = 0 # default value means we don't swap ordering by to disk diff --git a/posthog/hogql/database/schema/test/__snapshots__/test_session_replay_events.ambr b/posthog/hogql/database/schema/test/__snapshots__/test_session_replay_events.ambr index 954aa6629f821..d1265cfc0cb75 100644 --- a/posthog/hogql/database/schema/test/__snapshots__/test_session_replay_events.ambr +++ b/posthog/hogql/database/schema/test/__snapshots__/test_session_replay_events.ambr @@ -19,7 +19,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByConsoleLogs.test_select_by_console_log_text_and_level @@ -44,7 +45,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByConsoleLogs.test_select_log_text @@ -69,7 +71,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByEvents.test_select_by_event @@ -89,7 +92,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByEvents.test_select_by_event_property @@ -109,7 +113,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByEvents.test_select_event_property @@ -131,7 +136,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByPerson.test_select_by_event_person @@ -169,7 +175,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByPerson.test_select_by_person_distinct_id @@ -191,7 +198,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByPerson.test_select_by_replay_person @@ -220,7 +228,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByPerson.test_select_person_property @@ -255,7 +264,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByPerson.test_select_where_person_property_with_join_optimization @@ -290,7 +300,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysByPerson.test_select_where_person_property_without_join_optimization @@ -325,7 +336,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysBySessions.test_select_by_duration_with_session_duration_filter @@ -349,7 +361,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFilterSessionReplaysBySessions.test_select_by_duration_without_session_filter @@ -366,6 +379,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql/database/test/test_database.py b/posthog/hogql/database/test/test_database.py index cb380bce9da94..ab7f8a90db281 100644 --- a/posthog/hogql/database/test/test_database.py +++ b/posthog/hogql/database/test/test_database.py @@ -216,7 +216,7 @@ def test_database_with_warehouse_tables(self, patch_execute): self.assertEqual( response.clickhouse, - f"SELECT whatever.id AS id FROM s3(%(hogql_val_0_sensitive)s, %(hogql_val_3_sensitive)s, %(hogql_val_4_sensitive)s, %(hogql_val_1)s, %(hogql_val_2)s) AS whatever LIMIT 100 SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"SELECT whatever.id AS id FROM s3(%(hogql_val_0_sensitive)s, %(hogql_val_3_sensitive)s, %(hogql_val_4_sensitive)s, %(hogql_val_1)s, %(hogql_val_2)s) AS whatever LIMIT 100 SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) def test_database_group_type_mappings(self): diff --git a/posthog/hogql/functions/test/__snapshots__/test_cohort.ambr b/posthog/hogql/functions/test/__snapshots__/test_cohort.ambr index 7824d3b8f2cc2..c6b5635bbea2d 100644 --- a/posthog/hogql/functions/test/__snapshots__/test_cohort.ambr +++ b/posthog/hogql/functions/test/__snapshots__/test_cohort.ambr @@ -12,7 +12,7 @@ GROUP BY cohortpeople.person_id, cohortpeople.cohort_id, cohortpeople.version HAVING ifNull(greater(sum(cohortpeople.sign), 0), 0))), equals(events.event, %(hogql_val_0)s)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -38,7 +38,7 @@ FROM person_static_cohort WHERE and(equals(person_static_cohort.team_id, 420), equals(person_static_cohort.cohort_id, XX))))) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -62,7 +62,7 @@ FROM person_static_cohort WHERE and(equals(person_static_cohort.team_id, 420), equals(person_static_cohort.cohort_id, XX))))) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL diff --git a/posthog/hogql/functions/test/test_sparkline.py b/posthog/hogql/functions/test/test_sparkline.py index 57b6f9f8b26f6..105f80e43e9a4 100644 --- a/posthog/hogql/functions/test/test_sparkline.py +++ b/posthog/hogql/functions/test/test_sparkline.py @@ -8,7 +8,7 @@ def test_sparkline(self): response = execute_hogql_query("select sparkline([1,2,3])", self.team, pretty=False) self.assertEqual( response.clickhouse, - f"SELECT tuple(%(hogql_val_0)s, %(hogql_val_1)s, %(hogql_val_2)s, [1, 2, 3]) LIMIT 100 SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"SELECT tuple(%(hogql_val_0)s, %(hogql_val_1)s, %(hogql_val_2)s, [1, 2, 3]) LIMIT 100 SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) self.assertEqual( response.hogql, diff --git a/posthog/hogql/test/__snapshots__/test_query.ambr b/posthog/hogql/test/__snapshots__/test_query.ambr index 8daa49d38f6fa..322929782830c 100644 --- a/posthog/hogql/test/__snapshots__/test_query.ambr +++ b/posthog/hogql/test/__snapshots__/test_query.ambr @@ -5,7 +5,7 @@ SELECT [1, 2, 3], [10, 11, 12][1] LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -19,7 +19,7 @@ SELECT arrayMap(x -> multiply(x, 2), [1, 2, 3]), 1 LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -35,7 +35,7 @@ FROM events WHERE and(equals(events.team_id, 420), equals(events.distinct_id, %(hogql_val_0)s), ifNull(equals(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(events.properties, %(hogql_val_1)s), ''), 'null'), '^"|"$', ''), %(hogql_val_2)s), 0)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -62,7 +62,7 @@ FROM events WHERE and(equals(events.team_id, 420), equals(events.distinct_id, %(hogql_val_0)s), and(ifNull(equals(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(events.properties, %(hogql_val_1)s), ''), 'null'), '^"|"$', ''), %(hogql_val_2)s), 0), less(toTimeZone(events.timestamp, %(hogql_val_3)s), toDateTime64('2020-01-02 00:00:00.000000', 6, 'UTC')), greaterOrEquals(toTimeZone(events.timestamp, %(hogql_val_4)s), toDateTime64('2020-01-01 00:00:00.000000', 6, 'UTC')))) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -89,7 +89,7 @@ FROM events AS e WHERE and(equals(e.team_id, 420), ifNull(equals(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(e.properties, %(hogql_val_0)s), ''), 'null'), '^"|"$', ''), %(hogql_val_1)s), 0)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -111,7 +111,7 @@ FROM events WHERE equals(events.team_id, 420) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -135,7 +135,7 @@ GROUP BY session_replay_events.session_id) AS s ON equals(s.session_id, nullIf(nullIf(e.`$session_id`, ''), 'null')) WHERE and(equals(e.team_id, 420), isNotNull(nullIf(nullIf(e.`$session_id`, ''), 'null'))) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -166,7 +166,7 @@ GROUP BY session_replay_events.session_id) AS s LEFT JOIN events AS e ON equals(nullIf(nullIf(e.`$session_id`, ''), 'null'), s.session_id) WHERE and(equals(e.team_id, 420), isNotNull(nullIf(nullIf(e.`$session_id`, ''), 'null'))) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -197,7 +197,7 @@ GROUP BY session_replay_events.session_id) AS s ON equals(s.session_id, replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(e.properties, %(hogql_val_0)s), ''), 'null'), '^"|"$', '')) WHERE and(equals(e.team_id, 420), isNotNull(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(e.properties, %(hogql_val_1)s), ''), 'null'), '^"|"$', ''))) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -228,7 +228,7 @@ GROUP BY session_replay_events.session_id) AS s LEFT JOIN events AS e ON equals(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(e.properties, %(hogql_val_0)s), ''), 'null'), '^"|"$', ''), s.session_id) WHERE and(equals(e.team_id, 420), isNotNull(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(e.properties, %(hogql_val_1)s), ''), 'null'), '^"|"$', ''))) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -266,7 +266,7 @@ HAVING ifNull(greater(sum(cohortpeople.sign), 0), 0))), 0)) GROUP BY events.event LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -296,7 +296,7 @@ HAVING ifNull(greater(sum(cohortpeople.sign), 0), 0)))) GROUP BY events.event LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -329,7 +329,7 @@ WHERE and(equals(person_static_cohort.team_id, 420), equals(person_static_cohort.cohort_id, XX)))), 0)) GROUP BY events.event LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -355,7 +355,7 @@ WHERE and(equals(person_static_cohort.team_id, 420), equals(person_static_cohort.cohort_id, XX))))) GROUP BY events.event LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -378,7 +378,7 @@ WHERE and(equals(events.team_id, 420), ifNull(equals(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(events.properties, %(hogql_val_0)s), ''), 'null'), '^"|"$', ''), %(hogql_val_1)s), 0)) GROUP BY events.event LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -406,7 +406,7 @@ SETTINGS optimize_aggregation_in_order=1) AS persons WHERE ifNull(equals(persons.properties___random_uuid, %(hogql_val_3)s), 0) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -429,7 +429,7 @@ HAVING ifNull(equals(argMax(person_distinct_id2.is_deleted, person_distinct_id2.version), 0), 0)) AS e__pdi ON equals(e.distinct_id, e__pdi.distinct_id) WHERE equals(e.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -451,7 +451,7 @@ HAVING ifNull(equals(argMax(person_distinct_id2.is_deleted, person_distinct_id2.version), 0), 0)) AS events__pdi ON equals(events.distinct_id, events__pdi.distinct_id) WHERE equals(events.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -482,7 +482,7 @@ SETTINGS optimize_aggregation_in_order=1) AS e__pdi__person ON equals(e__pdi.e__pdi___person_id, e__pdi__person.id) WHERE equals(e.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -510,7 +510,7 @@ SETTINGS optimize_aggregation_in_order=1) AS events__pdi__person ON equals(events__pdi.events__pdi___person_id, events__pdi__person.id) WHERE equals(events.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -541,7 +541,7 @@ SETTINGS optimize_aggregation_in_order=1) AS events__pdi__person ON equals(events__pdi.events__pdi___person_id, events__pdi__person.id) WHERE equals(events.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -572,7 +572,7 @@ SETTINGS optimize_aggregation_in_order=1) AS e__pdi__person ON equals(e__pdi.e__pdi___person_id, e__pdi__person.id) WHERE equals(e.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -604,7 +604,7 @@ WHERE equals(s.team_id, 420) GROUP BY s__pdi__person.properties___sneaky_mail LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -627,7 +627,7 @@ HAVING ifNull(equals(argMax(person_distinct_id2.is_deleted, person_distinct_id2.version), 0), 0)) AS pdi ON equals(e.distinct_id, pdi.distinct_id) WHERE equals(e.team_id, 420) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -661,7 +661,7 @@ HAVING and(ifNull(equals(argMax(person.is_deleted, person.version), 0), 0), ifNull(less(argMax(person.created_at, person.version), plus(now64(6, %(hogql_val_1)s), toIntervalDay(1))), 0)))), 0)) SETTINGS optimize_aggregation_in_order=1) AS pdi__person ON equals(pdi.pdi___person_id, pdi__person.id) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -688,7 +688,7 @@ HAVING and(ifNull(equals(argMax(person.is_deleted, person.version), 0), 0), ifNull(less(argMax(person.created_at, person.version), plus(now64(6, %(hogql_val_0)s), toIntervalDay(1))), 0)) SETTINGS optimize_aggregation_in_order=1) AS pdi__person ON equals(pdi.pdi___person_id, pdi__person.id) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -719,7 +719,7 @@ SETTINGS optimize_aggregation_in_order=1) AS p ON equals(p.id, pdi.person_id) WHERE equals(e.team_id, 420) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -740,7 +740,7 @@ GROUP BY person_distinct_id2.distinct_id HAVING ifNull(equals(argMax(person_distinct_id2.is_deleted, person_distinct_id2.version), 0), 0)) AS person_distinct_ids LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -771,7 +771,7 @@ SETTINGS optimize_aggregation_in_order=1) AS events__pdi__person ON equals(events__pdi.events__pdi___person_id, events__pdi__person.id) WHERE equals(events.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -788,7 +788,7 @@ FROM events WHERE equals(events.team_id, 420) LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -806,7 +806,7 @@ WHERE equals(s.team_id, 420) GROUP BY replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(s.person_properties, %(hogql_val_1)s), ''), 'null'), '^"|"$', '') LIMIT 10 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -828,7 +828,7 @@ GROUP BY events.event) GROUP BY count, event LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -854,7 +854,7 @@ GROUP BY events.event) AS c GROUP BY c.count, c.event LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -883,7 +883,7 @@ GROUP BY col_a) GROUP BY col_a ORDER BY col_a ASC LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -916,7 +916,7 @@ GROUP BY PIVOT_TABLE_COL_ABC.col_a) AS PIVOT_FUNCTION_1 GROUP BY PIVOT_FUNCTION_1.col_a) AS PIVOT_FUNCTION_2 ORDER BY PIVOT_FUNCTION_2.col_a ASC LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -953,7 +953,7 @@ GROUP BY PIVOT_TABLE_COL_ABC.col_a) AS PIVOT_FUNCTION_1 GROUP BY PIVOT_FUNCTION_1.col_a) AS PIVOT_FUNCTION_2) AS final ORDER BY final.col_a ASC LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL diff --git a/posthog/hogql/test/test_printer.py b/posthog/hogql/test/test_printer.py index 5cd30291e1f0f..45a01b9820169 100644 --- a/posthog/hogql/test/test_printer.py +++ b/posthog/hogql/test/test_printer.py @@ -1221,7 +1221,7 @@ def test_print_global_settings(self): ) self.assertEqual( printed, - f"SELECT 1 FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"SELECT 1 FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) def test_print_query_level_settings(self): @@ -1248,7 +1248,7 @@ def test_print_both_settings(self): ) self.assertEqual( printed, - f"SELECT 1 FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS optimize_aggregation_in_order=1, readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"SELECT 1 FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS optimize_aggregation_in_order=1, readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) def test_pretty_print(self): @@ -1351,7 +1351,7 @@ def test_print_hidden_aliases_timestamp(self): printed, f"SELECT timestamp AS timestamp FROM (SELECT toTimeZone(events.timestamp, %(hogql_val_0)s), " f"toTimeZone(events.timestamp, %(hogql_val_1)s) AS timestamp FROM events WHERE equals(events.team_id, {self.team.pk})) " - f"LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) def test_print_hidden_aliases_column_override(self): @@ -1366,7 +1366,7 @@ def test_print_hidden_aliases_column_override(self): printed, f"SELECT event AS event FROM (SELECT toTimeZone(events.timestamp, %(hogql_val_0)s) AS event, " f"event FROM events WHERE equals(events.team_id, {self.team.pk})) " - f"LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) def test_print_hidden_aliases_properties(self): @@ -1389,7 +1389,7 @@ def test_print_hidden_aliases_properties(self): printed, f"SELECT `$browser` AS `$browser` FROM (SELECT nullIf(nullIf(events.`mat_$browser`, ''), 'null') AS `$browser` " f"FROM events WHERE equals(events.team_id, {self.team.pk})) LIMIT {MAX_SELECT_RETURNED_ROWS} " - f"SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) def test_print_hidden_aliases_double_property(self): @@ -1413,7 +1413,7 @@ def test_print_hidden_aliases_double_property(self): f"SELECT `$browser` AS `$browser` FROM (SELECT nullIf(nullIf(events.`mat_$browser`, ''), 'null'), " f"nullIf(nullIf(events.`mat_$browser`, ''), 'null') AS `$browser` " # only the second one gets the alias f"FROM events WHERE equals(events.team_id, {self.team.pk})) LIMIT {MAX_SELECT_RETURNED_ROWS} " - f"SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"SETTINGS readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", ) def test_lookup_domain_type(self): @@ -1429,7 +1429,7 @@ def test_lookup_domain_type(self): "SELECT dictGetOrNull('channel_definition_dict', 'domain_type', " "(cutToFirstSignificantSubdomain(coalesce(%(hogql_val_0)s, '')), 'source')) " f"FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ), printed, ) @@ -1447,7 +1447,7 @@ def test_lookup_paid_domain_type(self): "SELECT dictGetOrNull('channel_definition_dict', 'type_if_paid', " "(cutToFirstSignificantSubdomain(coalesce(%(hogql_val_0)s, '')), 'source')) " f"FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ), printed, ) @@ -1465,7 +1465,7 @@ def test_lookup_paid_source_type(self): "SELECT dictGetOrNull('channel_definition_dict', 'type_if_paid', " "(coalesce(%(hogql_val_0)s, ''), 'source')) " f"FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ), printed, ) @@ -1483,7 +1483,7 @@ def test_lookup_paid_medium_type(self): "SELECT dictGetOrNull('channel_definition_dict', 'type_if_paid', " "(coalesce(%(hogql_val_0)s, ''), 'medium')) " f"FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ), printed, ) @@ -1501,7 +1501,7 @@ def test_lookup_organic_domain_type(self): "SELECT dictGetOrNull('channel_definition_dict', 'type_if_organic', " "(cutToFirstSignificantSubdomain(coalesce(%(hogql_val_0)s, '')), 'source')) " f"FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ), printed, ) @@ -1519,7 +1519,7 @@ def test_lookup_organic_source_type(self): "SELECT dictGetOrNull('channel_definition_dict', 'type_if_organic', " "(coalesce(%(hogql_val_0)s, ''), 'source')) " f"FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ), printed, ) @@ -1537,7 +1537,7 @@ def test_lookup_organic_medium_type(self): "SELECT dictGetOrNull('channel_definition_dict', 'type_if_organic', " "(coalesce(%(hogql_val_0)s, ''), 'medium')) " f"FROM events WHERE equals(events.team_id, {self.team.pk}) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ), printed, ) @@ -1588,7 +1588,7 @@ def test_trim_leading_trailing_both(self): ) assert printed == ( f"SELECT trim(LEADING %(hogql_val_1)s FROM %(hogql_val_0)s), trim(TRAILING %(hogql_val_3)s FROM %(hogql_val_2)s), trim(BOTH %(hogql_val_5)s FROM %(hogql_val_4)s) LIMIT {MAX_SELECT_RETURNED_ROWS} SETTINGS " - "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288" + "readonly=2, max_execution_time=10, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0" ) query2 = parse_select("select trimLeft('media', 'xy'), trimRight('media', 'xy'), trim('media', 'xy')") printed2 = print_ast( diff --git a/posthog/hogql/test/test_query.py b/posthog/hogql/test/test_query.py index 278471152a9f5..8ba9638fe853f 100644 --- a/posthog/hogql/test/test_query.py +++ b/posthog/hogql/test/test_query.py @@ -997,7 +997,6 @@ def test_property_access_with_arrays(self): pretty=False, ) self.assertEqual( - response.clickhouse, f"SELECT " f"replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(events.properties, %(hogql_val_0)s), ''), 'null'), '^\"|\"$', '') AS string, " f"replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(events.properties, %(hogql_val_1)s, %(hogql_val_2)s), ''), 'null'), '^\"|\"$', ''), " @@ -1016,7 +1015,8 @@ def test_property_access_with_arrays(self): f"FROM events " f"WHERE and(equals(events.team_id, {self.team.pk}), ifNull(equals(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(events.properties, %(hogql_val_46)s), ''), 'null'), '^\"|\"$', ''), %(hogql_val_47)s), 0)) " f"LIMIT 100 " - f"SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288", + f"SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0", + response.clickhouse, ) self.assertEqual(response.results[0], tuple(random_uuid for x in alternatives)) diff --git a/posthog/hogql/transforms/test/__snapshots__/test_in_cohort.ambr b/posthog/hogql/transforms/test/__snapshots__/test_in_cohort.ambr index 6346ec092eba8..c7c60bb10b90e 100644 --- a/posthog/hogql/transforms/test/__snapshots__/test_in_cohort.ambr +++ b/posthog/hogql/transforms/test/__snapshots__/test_in_cohort.ambr @@ -10,7 +10,7 @@ WHERE and(equals(cohortpeople.team_id, 420), equals(cohortpeople.cohort_id, XX), equals(cohortpeople.version, 0))) AS __in_cohort ON equals(__in_cohort.cohort_person_id, events.person_id) WHERE and(equals(events.team_id, 420), and(1, equals(events.event, %(hogql_val_0)s)), ifNull(equals(__in_cohort.matched, 1), 0)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -34,7 +34,7 @@ WHERE and(equals(person_static_cohort.team_id, 420), in(person_static_cohort.cohort_id, [13]))) AS __in_cohort ON equals(__in_cohort.cohort_person_id, events.person_id) WHERE and(equals(events.team_id, 420), 1, ifNull(equals(__in_cohort.matched, 1), 0)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -58,7 +58,7 @@ WHERE and(equals(person_static_cohort.team_id, 420), in(person_static_cohort.cohort_id, [14]))) AS __in_cohort ON equals(__in_cohort.cohort_person_id, events.person_id) WHERE and(equals(events.team_id, 420), 1, ifNull(equals(__in_cohort.matched, 1), 0)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -84,7 +84,7 @@ HAVING ifNull(greater(sum(cohortpeople.sign), 0), 0)) AS in_cohort__XX ON equals(in_cohort__XX.person_id, events.person_id) WHERE and(equals(events.team_id, 420), ifNull(equals(in_cohort__XX.matched, 1), 0), equals(events.event, %(hogql_val_0)s)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -110,7 +110,7 @@ WHERE and(equals(person_static_cohort.team_id, 420), equals(person_static_cohort.cohort_id, XX))) AS in_cohort__XX ON equals(in_cohort__XX.person_id, events.person_id) WHERE and(equals(events.team_id, 420), ifNull(equals(in_cohort__XX.matched, 1), 0)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL @@ -134,7 +134,7 @@ WHERE and(equals(person_static_cohort.team_id, 420), equals(person_static_cohort.cohort_id, XX))) AS in_cohort__XX ON equals(in_cohort__XX.person_id, events.person_id) WHERE and(equals(events.team_id, 420), ifNull(equals(in_cohort__XX.matched, 1), 0)) LIMIT 100 - SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288 + SETTINGS readonly=2, max_execution_time=60, allow_experimental_object_type=1, format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, max_query_size=524288, max_bytes_before_external_group_by=0 -- HogQL diff --git a/posthog/hogql_queries/insights/funnels/funnels_query_runner.py b/posthog/hogql_queries/insights/funnels/funnels_query_runner.py index 1b85d8858302e..3ad62c08a1f66 100644 --- a/posthog/hogql_queries/insights/funnels/funnels_query_runner.py +++ b/posthog/hogql_queries/insights/funnels/funnels_query_runner.py @@ -1,4 +1,5 @@ from datetime import timedelta +from posthog.hogql.constants import HogQLGlobalSettings, MAX_BYTES_BEFORE_EXTERNAL_GROUP_BY from math import ceil from typing import Optional, Any @@ -95,6 +96,9 @@ def calculate(self): timings=self.timings, modifiers=self.modifiers, limit_context=self.limit_context, + settings=HogQLGlobalSettings( + max_bytes_before_external_group_by=MAX_BYTES_BEFORE_EXTERNAL_GROUP_BY + ), # Make sure funnel queries never OOM ) results = self.funnel_class._format_results(response.results) diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel.ambr index 324e27806cf5c..d9e0e5b8c2480 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel.ambr @@ -92,7 +92,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFOSSFunnel.test_funnel_conversion_window_seconds.1 @@ -198,7 +199,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFOSSFunnel.test_funnel_events_with_person_on_events_v2 @@ -303,7 +305,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFOSSFunnel.test_funnel_with_precalculated_cohort_step_filter @@ -389,7 +392,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFOSSFunnel.test_funnel_with_property_groups @@ -497,7 +501,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFOSSFunnel.test_funnel_with_property_groups.1 @@ -615,7 +620,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFOSSFunnel.test_funnel_with_property_groups.2 @@ -733,7 +739,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFOSSFunnel.test_funnel_with_property_groups.3 @@ -851,7 +858,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFOSSFunnel.test_funnel_with_static_cohort_step_filter @@ -926,7 +934,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFOSSFunnel.test_timezones @@ -989,7 +998,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelBreakdown.test_funnel_breakdown_correct_breakdown_props_are_chosen @@ -1085,7 +1095,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelBreakdown.test_funnel_breakdown_correct_breakdown_props_are_chosen_for_step @@ -1188,7 +1199,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelBreakdown.test_funnel_step_multiple_breakdown_snapshot @@ -1284,7 +1296,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelGroupBreakdown.test_funnel_aggregate_by_groups_breakdown_group_person_on_events @@ -1421,7 +1434,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelGroupBreakdown.test_funnel_aggregate_by_groups_breakdown_group_person_on_events_poe_v2 @@ -1558,7 +1572,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelGroupBreakdown.test_funnel_breakdown_group @@ -1702,7 +1717,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelGroupBreakdown.test_funnel_breakdown_group.1 diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_breakdowns_by_current_url.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_breakdowns_by_current_url.ambr index 8e138dcfe970d..71ca317b20bb7 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_breakdowns_by_current_url.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_breakdowns_by_current_url.ambr @@ -92,7 +92,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelBreakdownsByCurrentURL.test_breakdown_by_pathname @@ -188,6 +189,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlation.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlation.ambr index 0626457a961a1..4d1ba34adce68 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlation.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlation.ambr @@ -149,7 +149,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties @@ -311,7 +312,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.1 @@ -444,7 +446,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.2 @@ -458,7 +461,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.3 @@ -591,7 +595,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.4 @@ -605,7 +610,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.5 @@ -738,7 +744,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.6 @@ -752,7 +759,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.7 @@ -885,7 +893,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties.8 @@ -899,7 +908,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized @@ -1061,7 +1071,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.1 @@ -1194,7 +1205,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.2 @@ -1208,7 +1220,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.3 @@ -1341,7 +1354,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.4 @@ -1355,7 +1369,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.5 @@ -1488,7 +1503,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.6 @@ -1502,7 +1518,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.7 @@ -1635,7 +1652,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_basic_funnel_correlation_with_properties_materialized.8 @@ -1649,7 +1667,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_event_properties_and_groups @@ -1787,7 +1806,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_event_properties_and_groups_materialized @@ -1925,7 +1945,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups @@ -2057,7 +2078,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups.1 @@ -2172,7 +2194,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups.2 @@ -2287,7 +2310,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups.3 @@ -2402,7 +2426,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups.4 @@ -2517,7 +2542,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups.5 @@ -2665,7 +2691,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups.6 @@ -2780,7 +2807,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups.7 @@ -2895,7 +2923,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2 @@ -3027,7 +3056,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2.1 @@ -3142,7 +3172,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2.2 @@ -3257,7 +3288,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2.3 @@ -3372,7 +3404,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2.4 @@ -3487,7 +3520,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2.5 @@ -3635,7 +3669,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2.6 @@ -3750,7 +3785,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_events_and_groups_poe_v2.7 @@ -3865,7 +3901,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups @@ -4012,7 +4049,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups.1 @@ -4134,7 +4172,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups.2 @@ -4256,7 +4295,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups.3 @@ -4378,7 +4418,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups.4 @@ -4500,7 +4541,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups.5 @@ -4647,7 +4689,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_materialized @@ -4794,7 +4837,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_materialized.1 @@ -4916,7 +4960,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_materialized.2 @@ -5038,7 +5083,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_materialized.3 @@ -5160,7 +5206,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_materialized.4 @@ -5282,7 +5329,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_materialized.5 @@ -5429,7 +5477,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events @@ -5576,7 +5625,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events.1 @@ -5698,7 +5748,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events.2 @@ -5820,7 +5871,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events.3 @@ -5942,7 +5994,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events.4 @@ -6064,7 +6117,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events.5 @@ -6211,7 +6265,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_materialized @@ -6358,7 +6413,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_materialized.1 @@ -6480,7 +6536,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_materialized.2 @@ -6602,7 +6659,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_materialized.3 @@ -6724,7 +6782,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_materialized.4 @@ -6846,7 +6905,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_materialized.5 @@ -6993,7 +7053,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_poe_v2 @@ -7140,7 +7201,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_poe_v2.1 @@ -7262,7 +7324,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_poe_v2.2 @@ -7384,7 +7447,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_poe_v2.3 @@ -7506,7 +7570,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_poe_v2.4 @@ -7628,7 +7693,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseFunnelCorrelation.test_funnel_correlation_with_properties_and_groups_person_on_events_poe_v2.5 @@ -7775,6 +7841,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlations_persons.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlations_persons.ambr index 03d0a3d50398e..4f6c68ea6c6b9 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlations_persons.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_correlations_persons.ambr @@ -126,7 +126,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_funnel_correlation_on_event_with_recordings.1 @@ -140,7 +141,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_funnel_correlation_on_event_with_recordings.2 @@ -336,7 +338,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_funnel_correlation_on_event_with_recordings.3 @@ -350,7 +353,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_funnel_correlation_on_properties_with_recordings @@ -483,7 +487,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_funnel_correlation_on_properties_with_recordings.1 @@ -497,7 +502,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_strict_funnel_correlation_with_recordings @@ -630,7 +636,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_strict_funnel_correlation_with_recordings.1 @@ -644,7 +651,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_strict_funnel_correlation_with_recordings.2 @@ -777,7 +785,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelCorrelationsActors.test_strict_funnel_correlation_with_recordings.3 @@ -791,6 +800,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_persons.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_persons.ambr index c523cd266bd48..18bfe7e9fb732 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_persons.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_persons.ambr @@ -168,7 +168,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelPersons.test_funnel_person_recordings.1 @@ -182,7 +183,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelPersons.test_funnel_person_recordings.2 @@ -354,7 +356,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelPersons.test_funnel_person_recordings.3 @@ -368,7 +371,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelPersons.test_funnel_person_recordings.4 @@ -540,7 +544,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelPersons.test_funnel_person_recordings.5 @@ -554,6 +559,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict.ambr index 4112a08b4fec7..573f126c3ab4f 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict.ambr @@ -91,7 +91,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelStrictStepsBreakdown.test_funnel_breakdown_correct_breakdown_props_are_chosen_for_step @@ -193,7 +194,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelStrictStepsBreakdown.test_funnel_step_multiple_breakdown_snapshot @@ -288,7 +290,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestStrictFunnelGroupBreakdown.test_funnel_aggregate_by_groups_breakdown_group_person_on_events @@ -402,7 +405,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestStrictFunnelGroupBreakdown.test_funnel_aggregate_by_groups_breakdown_group_person_on_events_poe_v2 @@ -516,7 +520,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestStrictFunnelGroupBreakdown.test_funnel_breakdown_group @@ -637,7 +642,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestStrictFunnelGroupBreakdown.test_funnel_breakdown_group.1 diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict_persons.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict_persons.ambr index 87640c256abd8..49b02ae1302e5 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict_persons.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_strict_persons.ambr @@ -128,7 +128,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelStrictStepsPersons.test_strict_funnel_person_recordings.1 @@ -142,7 +143,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelStrictStepsPersons.test_strict_funnel_person_recordings.2 @@ -274,7 +276,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelStrictStepsPersons.test_strict_funnel_person_recordings.3 @@ -288,7 +291,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelStrictStepsPersons.test_strict_funnel_person_recordings.4 @@ -420,7 +424,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelStrictStepsPersons.test_strict_funnel_person_recordings.5 @@ -434,6 +439,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_time_to_convert.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_time_to_convert.ambr index cf19a01c3c776..0941ab1b87ce8 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_time_to_convert.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_time_to_convert.ambr @@ -415,7 +415,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelTimeToConvert.test_basic_strict @@ -761,7 +762,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelTimeToConvert.test_basic_unordered @@ -1507,6 +1509,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends.ambr index 66c82ab0ed7e0..fa7a5587a95ed 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends.ambr @@ -87,7 +87,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelTrends.test_timezones_trends.1 @@ -178,7 +179,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelTrends.test_week_interval @@ -269,7 +271,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelTrends.test_week_interval.1 diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends_persons.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends_persons.ambr index 39f1623bdef63..07d851cf6d324 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends_persons.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_trends_persons.ambr @@ -154,7 +154,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelTrendsPersons.test_funnel_trend_persons_returns_recordings.1 @@ -168,7 +169,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelTrendsPersons.test_funnel_trend_persons_with_drop_off @@ -326,7 +328,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelTrendsPersons.test_funnel_trend_persons_with_drop_off.1 @@ -340,7 +343,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelTrendsPersons.test_funnel_trend_persons_with_no_to_step @@ -498,7 +502,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestFunnelTrendsPersons.test_funnel_trend_persons_with_no_to_step.1 @@ -512,6 +517,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered.ambr index 8119692fee6f2..2839d58ff8b58 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered.ambr @@ -145,7 +145,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelUnorderedStepsBreakdown.test_funnel_breakdown_correct_breakdown_props_are_chosen_for_step @@ -308,7 +309,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestFunnelUnorderedStepsBreakdown.test_funnel_step_multiple_breakdown_snapshot @@ -457,7 +459,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestUnorderedFunnelGroupBreakdown.test_funnel_aggregate_by_groups_breakdown_group_person_on_events @@ -701,7 +704,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestUnorderedFunnelGroupBreakdown.test_funnel_aggregate_by_groups_breakdown_group_person_on_events_poe_v2 @@ -945,7 +949,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestUnorderedFunnelGroupBreakdown.test_funnel_breakdown_group @@ -1210,7 +1215,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestUnorderedFunnelGroupBreakdown.test_funnel_breakdown_group.1 diff --git a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered_persons.ambr b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered_persons.ambr index c426b64f3dbb1..7710fd9dc8aa8 100644 --- a/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered_persons.ambr +++ b/posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered_persons.ambr @@ -272,6 +272,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/paths_query_runner.py b/posthog/hogql_queries/insights/paths_query_runner.py index 30185e28f8923..58daf98e2d737 100644 --- a/posthog/hogql_queries/insights/paths_query_runner.py +++ b/posthog/hogql_queries/insights/paths_query_runner.py @@ -1,4 +1,5 @@ import itertools +from posthog.hogql.constants import HogQLGlobalSettings, MAX_BYTES_BEFORE_EXTERNAL_GROUP_BY from collections import defaultdict from datetime import datetime, timedelta from math import ceil @@ -857,6 +858,9 @@ def calculate(self) -> PathsQueryResponse: timings=self.timings, modifiers=self.modifiers, limit_context=self.limit_context, + settings=HogQLGlobalSettings( + max_bytes_before_external_group_by=MAX_BYTES_BEFORE_EXTERNAL_GROUP_BY + ), # Make sure funnel queries never OOM ) response.results = self.validate_results(response.results) diff --git a/posthog/hogql_queries/insights/retention_query_runner.py b/posthog/hogql_queries/insights/retention_query_runner.py index 7bbd39e6c14ff..87dfc810812b3 100644 --- a/posthog/hogql_queries/insights/retention_query_runner.py +++ b/posthog/hogql_queries/insights/retention_query_runner.py @@ -1,6 +1,7 @@ from datetime import datetime, timedelta from posthog.hogql.property import property_to_expr from posthog.hogql.parser import parse_expr, parse_select +from posthog.hogql.constants import HogQLGlobalSettings, MAX_BYTES_BEFORE_EXTERNAL_GROUP_BY from math import ceil from typing import Any from typing import Optional @@ -384,6 +385,7 @@ def calculate(self) -> RetentionQueryResponse: timings=self.timings, modifiers=self.modifiers, limit_context=self.limit_context, + settings=HogQLGlobalSettings(max_bytes_before_external_group_by=MAX_BYTES_BEFORE_EXTERNAL_GROUP_BY), ) result_dict = { diff --git a/posthog/hogql_queries/insights/test/__snapshots__/test_lifecycle_query_runner.ambr b/posthog/hogql_queries/insights/test/__snapshots__/test_lifecycle_query_runner.ambr index 4a5f773c4d869..7e0475cc8c97c 100644 --- a/posthog/hogql_queries/insights/test/__snapshots__/test_lifecycle_query_runner.ambr +++ b/posthog/hogql_queries/insights/test/__snapshots__/test_lifecycle_query_runner.ambr @@ -95,7 +95,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestLifecycleQueryRunner.test_sampling @@ -171,7 +172,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestLifecycleQueryRunner.test_timezones @@ -247,7 +249,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestLifecycleQueryRunner.test_timezones.1 @@ -323,6 +326,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/test/__snapshots__/test_paths_query_runner_ee.ambr b/posthog/hogql_queries/insights/test/__snapshots__/test_paths_query_runner_ee.ambr index 1e993624d4131..da4c647db0bed 100644 --- a/posthog/hogql_queries/insights/test/__snapshots__/test_paths_query_runner_ee.ambr +++ b/posthog/hogql_queries/insights/test/__snapshots__/test_paths_query_runner_ee.ambr @@ -79,7 +79,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_end.1 @@ -162,7 +163,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_end_materialized @@ -245,7 +247,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_end_materialized.1 @@ -328,7 +331,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_event_exclusion_filters_with_wildcard_groups @@ -410,7 +414,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_event_exclusion_filters_with_wildcard_groups.1 @@ -492,7 +497,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_event_inclusion_exclusion_filters @@ -574,7 +580,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_event_inclusion_exclusion_filters.1 @@ -656,7 +663,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_event_inclusion_exclusion_filters.2 @@ -738,7 +746,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_event_inclusion_exclusion_filters.3 @@ -820,7 +829,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_event_ordering @@ -902,7 +912,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_groups_filtering_person_on_events @@ -992,7 +1003,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_groups_filtering_person_on_events.1 @@ -1075,7 +1087,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_groups_filtering_person_on_events.2 @@ -1158,7 +1171,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_person_dropoffs @@ -1278,7 +1292,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.1 @@ -1397,7 +1412,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.2 @@ -1516,7 +1532,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.3 @@ -1636,7 +1653,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.4 @@ -1755,7 +1773,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.5 @@ -1874,7 +1893,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.6 @@ -1994,7 +2014,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.7 @@ -2113,7 +2134,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_dropoffs.8 @@ -2232,7 +2254,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_person_on_events_v2 @@ -2323,7 +2346,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_recording @@ -2446,7 +2470,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording.1 @@ -2460,7 +2485,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording_for_dropoff @@ -2584,7 +2610,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording_for_dropoff.1 @@ -2708,7 +2735,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording_for_dropoff.2 @@ -2722,7 +2750,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording_with_no_window_or_session_id @@ -2845,7 +2874,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording_with_no_window_or_session_id.1 @@ -2859,7 +2889,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording_with_start_and_end @@ -2991,7 +3022,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_recording_with_start_and_end.1 @@ -3005,7 +3037,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_respect_session_limits @@ -3087,7 +3120,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_start_and_end @@ -3174,7 +3208,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_start_and_end.1 @@ -3302,7 +3337,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_start_and_end.2 @@ -3389,7 +3425,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_start_and_end.3 @@ -3517,7 +3554,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_start_and_end_materialized @@ -3604,7 +3642,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_start_and_end_materialized.1 @@ -3732,7 +3771,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_start_and_end_materialized.2 @@ -3819,7 +3859,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_start_and_end_materialized.3 @@ -3947,7 +3988,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_start_dropping_orphaned_edges @@ -4030,7 +4072,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_step_conversion_times @@ -4112,7 +4155,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_step_limit @@ -4194,7 +4238,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_step_limit.1 @@ -4313,7 +4358,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_step_limit.2 @@ -4432,7 +4478,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_step_limit.3 @@ -4514,7 +4561,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_step_limit.4 @@ -4633,7 +4681,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_step_limit.5 @@ -4715,7 +4764,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_step_limit.6 @@ -4834,7 +4884,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_step_limit.7 @@ -4953,7 +5004,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_step_limit.8 @@ -5072,7 +5124,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhousePaths.test_wildcard_groups_across_people @@ -5154,7 +5207,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhousePaths.test_wildcard_groups_evil_input @@ -5241,6 +5295,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- diff --git a/posthog/hogql_queries/insights/test/__snapshots__/test_retention_query_runner.ambr b/posthog/hogql_queries/insights/test/__snapshots__/test_retention_query_runner.ambr index 563ac22a583aa..a793e4e6022b1 100644 --- a/posthog/hogql_queries/insights/test/__snapshots__/test_retention_query_runner.ambr +++ b/posthog/hogql_queries/insights/test/__snapshots__/test_retention_query_runner.ambr @@ -24,7 +24,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhouseRetentionGroupAggregation.test_groups_aggregating.1 @@ -69,7 +70,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseRetentionGroupAggregation.test_groups_aggregating.2 @@ -97,7 +99,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhouseRetentionGroupAggregation.test_groups_aggregating_person_on_events @@ -125,7 +128,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestClickhouseRetentionGroupAggregation.test_groups_aggregating_person_on_events.1 @@ -170,7 +174,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestClickhouseRetentionGroupAggregation.test_groups_aggregating_person_on_events.2 @@ -198,7 +203,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_day_interval_sampled @@ -233,7 +239,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_month_interval_with_person_on_events_v2 @@ -277,7 +284,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_retention_event_action @@ -312,7 +320,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_retention_with_user_properties_via_action @@ -358,7 +367,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_timezones @@ -393,7 +403,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_timezones.1 @@ -428,7 +439,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_week_interval @@ -463,7 +475,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- # name: TestRetention.test_week_interval.1 @@ -498,6 +511,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=23622320128 ''' # --- diff --git a/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends.ambr b/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends.ambr index 22187de2c8b0d..91d53547b1942 100644 --- a/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends.ambr +++ b/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends.ambr @@ -93,7 +93,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_action_filtering_with_cohort_poe_v2 @@ -179,7 +180,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_by_group_props_person_on_events @@ -226,7 +228,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_by_group_props_person_on_events.1 @@ -271,7 +274,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_by_group_props_person_on_events.2 @@ -285,7 +289,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_by_group_props_person_on_events.3 @@ -346,7 +351,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_by_group_props_with_person_filter_person_on_events.1 @@ -426,7 +432,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_filtering_with_properties_in_new_format.1 @@ -465,7 +472,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_filtering_with_properties_in_new_format.2 @@ -557,7 +565,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_weekly_active_users_aggregated.1 @@ -641,7 +650,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_weekly_active_users_aggregated_materialized.1 @@ -779,7 +789,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_weekly_active_users_daily_based_on_action.3 @@ -896,7 +907,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_with_filter_groups_person_on_events.1 @@ -1000,7 +1012,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_breakdown_with_filter_groups_person_on_events_v2.2 @@ -1094,7 +1107,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_dau_with_breakdown_filtering_with_sampling.1 @@ -1140,7 +1154,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_dau_with_breakdown_filtering_with_sampling.2 @@ -1281,7 +1296,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_filter_events_by_precalculated_cohort_poe_v2 @@ -1347,7 +1363,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_filtering_by_multiple_groups_person_on_events @@ -1389,7 +1406,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_filtering_by_multiple_groups_person_on_events.1 @@ -1442,7 +1460,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_filtering_by_multiple_groups_person_on_events.2 @@ -1456,7 +1475,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_filtering_with_group_props_person_on_events @@ -1490,7 +1510,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_mau_with_breakdown_filtering_and_prop_filter @@ -1564,7 +1585,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_mau_with_breakdown_filtering_and_prop_filter.1 @@ -1694,7 +1716,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_mau_with_breakdown_filtering_and_prop_filter_poe_v2.1 @@ -1776,7 +1799,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_filtering_in_cohort_in_action @@ -1845,7 +1869,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_filtering_in_cohort_in_action.3 @@ -1957,7 +1982,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_filtering_in_cohort_in_action_poe_v2.3 @@ -2044,7 +2070,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_property_filtering_clashing_with_event_property @@ -2088,7 +2115,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_property_filtering_clashing_with_event_property.1 @@ -2114,7 +2142,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_property_filtering_clashing_with_event_property_materialized @@ -2158,7 +2187,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_property_filtering_clashing_with_event_property_materialized.1 @@ -2184,7 +2214,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_person_property_filtering_materialized @@ -2228,7 +2259,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_same_day_with_person_on_events_v2 @@ -2263,7 +2295,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_same_day_with_person_on_events_v2.2 @@ -2296,7 +2329,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_same_day_with_person_on_events_v2_latest_override @@ -2338,7 +2372,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_same_day_with_person_on_events_v2_latest_override.2 @@ -2380,7 +2415,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_same_day_with_person_on_events_v2_latest_override.4 @@ -2422,7 +2458,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily @@ -2448,7 +2485,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily.1 @@ -2481,7 +2519,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily.2 @@ -2527,7 +2566,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily.3 @@ -2553,7 +2593,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily.4 @@ -2599,7 +2640,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily.5 @@ -2665,7 +2707,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_minus_utc.1 @@ -2698,7 +2741,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_minus_utc.2 @@ -2744,7 +2788,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_minus_utc.3 @@ -2770,7 +2815,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_minus_utc.4 @@ -2816,7 +2862,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_minus_utc.5 @@ -2882,7 +2929,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_plus_utc.1 @@ -2915,7 +2963,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_plus_utc.2 @@ -2961,7 +3010,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_plus_utc.3 @@ -2987,7 +3037,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_plus_utc.4 @@ -3033,7 +3084,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_daily_plus_utc.5 @@ -3106,7 +3158,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_hourly_relative_from.1 @@ -3132,7 +3185,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_hourly_relative_from_minus_utc @@ -3165,7 +3219,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_hourly_relative_from_minus_utc.1 @@ -3191,7 +3246,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_hourly_relative_from_plus_utc @@ -3224,7 +3280,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_hourly_relative_from_plus_utc.1 @@ -3250,7 +3307,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_weekly @@ -3276,7 +3334,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_weekly.1 @@ -3302,7 +3361,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_weekly_minus_utc @@ -3328,7 +3388,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_weekly_minus_utc.1 @@ -3354,7 +3415,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_weekly_plus_utc @@ -3380,7 +3442,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_timezones_weekly_plus_utc.1 @@ -3406,7 +3469,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trend_breakdown_user_props_with_filter_with_partial_property_pushdowns @@ -3465,7 +3529,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trend_breakdown_user_props_with_filter_with_partial_property_pushdowns.1 @@ -3524,7 +3589,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trend_breakdown_user_props_with_filter_with_partial_property_pushdowns.2 @@ -3640,7 +3706,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_aggregate_by_distinct_id.1 @@ -3684,7 +3751,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_aggregate_by_distinct_id.2 @@ -3741,7 +3809,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_aggregate_by_distinct_id.3 @@ -3780,7 +3849,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_aggregate_by_distinct_id.4 @@ -3819,7 +3889,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_aggregate_by_distinct_id.5 @@ -3858,7 +3929,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_aggregate_by_distinct_id.6 @@ -3934,7 +4006,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_any_event_total_count.1 @@ -3960,7 +4033,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_breakdown_cumulative @@ -4012,7 +4086,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_breakdown_cumulative.1 @@ -4110,7 +4185,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_breakdown_cumulative_poe_v2.1 @@ -4210,7 +4286,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_breakdown_normalize_url.1 @@ -4287,7 +4364,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_breakdown_with_session_property_single_aggregate_math_and_breakdown.1 @@ -4316,7 +4394,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_breakdown_with_session_property_single_aggregate_math_and_breakdown.2 @@ -4394,7 +4473,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_compare_day_interval_relative_range.1 @@ -4420,7 +4500,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_compare_day_interval_relative_range.2 @@ -4446,7 +4527,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_count_per_user_average_aggregated @@ -4472,7 +4554,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_count_per_user_average_aggregated_poe_v2 @@ -4498,7 +4581,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_count_per_user_average_aggregated_with_event_property_breakdown_with_sampling @@ -4529,7 +4613,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_count_per_user_average_aggregated_with_event_property_breakdown_with_sampling.1 @@ -4601,7 +4686,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_count_per_user_average_daily_poe_v2 @@ -4642,7 +4728,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_groups_per_day @@ -4668,7 +4755,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_groups_per_day_cumulative @@ -4699,7 +4787,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_per_day_cumulative @@ -4730,7 +4819,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_per_day_dau_cumulative @@ -4768,7 +4858,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_person_breakdown_with_session_property_single_aggregate_math_and_breakdown @@ -4815,7 +4906,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_person_breakdown_with_session_property_single_aggregate_math_and_breakdown.1 @@ -4887,7 +4979,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_with_session_property_single_aggregate_math @@ -4912,7 +5005,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_with_session_property_single_aggregate_math.1 @@ -4937,7 +5031,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_with_session_property_total_volume_math @@ -4976,7 +5071,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_with_session_property_total_volume_math.1 @@ -5015,7 +5111,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_with_session_property_total_volume_math_with_breakdowns @@ -5069,7 +5166,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_with_session_property_total_volume_math_with_breakdowns.1 @@ -5123,7 +5221,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_trends_with_session_property_total_volume_math_with_breakdowns.2 @@ -5231,7 +5330,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_aggregated_range_wider_than_week @@ -5267,7 +5367,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_aggregated_range_wider_than_week_with_sampling @@ -5303,7 +5404,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_daily @@ -5349,7 +5451,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_daily_minus_utc @@ -5395,7 +5498,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_daily_plus_utc @@ -5441,7 +5545,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_filtering @@ -5498,7 +5603,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_filtering_materialized @@ -5555,7 +5661,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_hourly @@ -5601,7 +5708,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_weekly @@ -5647,7 +5755,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_weekly_minus_utc @@ -5693,7 +5802,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrends.test_weekly_active_users_weekly_plus_utc @@ -5739,6 +5849,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends_data_warehouse_query.ambr b/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends_data_warehouse_query.ambr index 4141c0043dea9..09625ed9a847c 100644 --- a/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends_data_warehouse_query.ambr +++ b/posthog/hogql_queries/insights/trends/test/__snapshots__/test_trends_data_warehouse_query.ambr @@ -35,7 +35,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrendsDataWarehouseQuery.test_trends_breakdown.1 @@ -107,7 +108,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrendsDataWarehouseQuery.test_trends_breakdown_with_property.1 @@ -166,7 +168,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrendsDataWarehouseQuery.test_trends_entity_property @@ -192,7 +195,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestTrendsDataWarehouseQuery.test_trends_property @@ -218,6 +222,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/hogql_queries/test/__snapshots__/test_sessions_timeline_query_runner.ambr b/posthog/hogql_queries/test/__snapshots__/test_sessions_timeline_query_runner.ambr index 9cc44caf3ff52..09e38bf5e13ac 100644 --- a/posthog/hogql_queries/test/__snapshots__/test_sessions_timeline_query_runner.ambr +++ b/posthog/hogql_queries/test/__snapshots__/test_sessions_timeline_query_runner.ambr @@ -64,7 +64,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionsTimelineQueryRunner.test_before_and_after_defaults @@ -132,7 +133,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionsTimelineQueryRunner.test_event_limit_and_has_more @@ -200,7 +202,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionsTimelineQueryRunner.test_formal_and_informal_sessions_global @@ -268,7 +271,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionsTimelineQueryRunner.test_formal_session_with_recording @@ -336,7 +340,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionsTimelineQueryRunner.test_formal_sessions_for_person @@ -404,7 +409,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionsTimelineQueryRunner.test_formal_sessions_global @@ -472,6 +478,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- diff --git a/posthog/session_recordings/queries/test/__snapshots__/test_session_recording_list_from_filters.ambr b/posthog/session_recordings/queries/test/__snapshots__/test_session_recording_list_from_filters.ambr index f07ec709ed46f..d5aceabdff1e3 100644 --- a/posthog/session_recordings/queries/test/__snapshots__/test_session_recording_list_from_filters.ambr +++ b/posthog/session_recordings/queries/test/__snapshots__/test_session_recording_list_from_filters.ambr @@ -33,7 +33,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_action_filter.1 @@ -70,7 +71,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_action_filter.2 @@ -107,7 +109,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_action_filter.3 @@ -144,7 +147,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_all_filters_at_once @@ -189,7 +193,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_any_event_filter_with_properties @@ -226,7 +231,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_any_event_filter_with_properties.1 @@ -263,7 +269,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_any_event_filter_with_properties.2 @@ -300,7 +307,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_any_event_filter_with_properties_materialized @@ -337,7 +345,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_any_event_filter_with_properties_materialized.1 @@ -374,7 +383,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_any_event_filter_with_properties_materialized.2 @@ -411,7 +421,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query @@ -443,7 +454,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_active_sessions @@ -475,7 +487,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_active_sessions.1 @@ -507,7 +520,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_active_sessions.2 @@ -539,7 +553,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_with_ordering @@ -571,7 +586,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_with_ordering.1 @@ -603,7 +619,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_with_ordering.2 @@ -635,7 +652,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_with_paging @@ -667,7 +685,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_with_paging.1 @@ -699,7 +718,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_basic_query_with_paging.2 @@ -731,7 +751,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_date_from_filter @@ -763,7 +784,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_date_from_filter.1 @@ -795,7 +817,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_date_from_filter_cannot_search_before_ttl @@ -827,7 +850,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_date_from_filter_cannot_search_before_ttl.1 @@ -859,7 +883,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_date_from_filter_cannot_search_before_ttl.2 @@ -891,7 +916,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_date_to_filter @@ -923,7 +949,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_date_to_filter.1 @@ -955,7 +982,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_duration_filter @@ -987,7 +1015,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_duration_filter.1 @@ -1019,7 +1048,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter @@ -1056,7 +1086,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter.1 @@ -1093,7 +1124,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_has_ttl_applied_too @@ -1130,7 +1162,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_has_ttl_applied_too.1 @@ -1162,7 +1195,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_active_sessions @@ -1199,7 +1233,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_active_sessions.1 @@ -1236,7 +1271,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_group_filter @@ -1278,7 +1314,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_event_properties_test_accounts_excluded @@ -1315,7 +1352,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_event_properties_test_accounts_excluded.1 @@ -1369,7 +1407,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_event_properties_test_accounts_excluded.2 @@ -1423,7 +1462,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_event_properties_test_accounts_excluded_materialized @@ -1460,7 +1500,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_event_properties_test_accounts_excluded_materialized.1 @@ -1514,7 +1555,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_event_properties_test_accounts_excluded_materialized.2 @@ -1568,7 +1610,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_person_properties @@ -1620,7 +1663,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_person_properties.1 @@ -1672,7 +1716,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_properties @@ -1709,7 +1754,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_properties.1 @@ -1746,7 +1792,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_properties_materialized @@ -1783,7 +1830,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_hogql_properties_materialized.1 @@ -1820,7 +1868,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_matching_on_session_id @@ -1857,7 +1906,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_matching_on_session_id.1 @@ -1894,7 +1944,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties @@ -1931,7 +1982,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties.1 @@ -1968,7 +2020,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties.2 @@ -2005,7 +2058,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties.3 @@ -2042,7 +2096,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties_materialized @@ -2079,7 +2134,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties_materialized.1 @@ -2116,7 +2172,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties_materialized.2 @@ -2153,7 +2210,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_properties_materialized.3 @@ -2190,7 +2248,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_test_accounts_excluded @@ -2244,7 +2303,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_test_accounts_excluded.1 @@ -2281,7 +2341,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_test_accounts_excluded_materialized @@ -2335,7 +2396,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_test_accounts_excluded_materialized.1 @@ -2372,7 +2434,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_event_filter_with_two_events_and_multiple_teams @@ -2409,7 +2472,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_by_console_text @@ -2447,7 +2511,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_by_console_text.1 @@ -2485,7 +2550,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_by_console_text.2 @@ -2523,7 +2589,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_by_console_text.3 @@ -2561,7 +2628,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_console_errors @@ -2599,7 +2667,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_console_errors.1 @@ -2637,7 +2706,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_console_logs @@ -2675,7 +2745,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_console_logs.1 @@ -2713,7 +2784,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_console_warns @@ -2751,7 +2823,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_console_warns.1 @@ -2789,7 +2862,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_mixed_console_counts @@ -2827,7 +2901,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_for_recordings_with_mixed_console_counts.1 @@ -2865,7 +2940,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_on_session_ids @@ -2902,7 +2978,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_on_session_ids.1 @@ -2939,7 +3016,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_with_cohort_properties @@ -3001,7 +3079,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_with_events_and_cohorts @@ -3068,7 +3147,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_with_events_and_cohorts.3 @@ -3115,7 +3195,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_with_person_properties_exact @@ -3164,7 +3245,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_filter_with_person_properties_not_contains @@ -3213,7 +3295,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_multiple_event_filters @@ -3250,7 +3333,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_multiple_event_filters.1 @@ -3699,7 +3783,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_person_id_filter @@ -3739,7 +3824,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter @@ -3776,7 +3862,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter.1 @@ -3813,7 +3900,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter_allowing_denormalized_props @@ -3850,7 +3938,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter_allowing_denormalized_props.1 @@ -3887,7 +3976,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter_allowing_denormalized_props_materialized @@ -3924,7 +4014,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter_allowing_denormalized_props_materialized.1 @@ -3961,7 +4052,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter_materialized @@ -3998,7 +4090,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_event_property_test_account_filter_materialized.1 @@ -4035,7 +4128,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_event_property_test_account_filter @@ -4072,7 +4166,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_event_property_test_account_filter.1 @@ -4109,7 +4204,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_event_property_test_account_filter_materialized @@ -4146,7 +4242,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_event_property_test_account_filter_materialized.1 @@ -4183,7 +4280,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_person_property_test_account_filter @@ -4220,7 +4318,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_person_property_test_account_filter.1 @@ -4269,7 +4368,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_person_property_test_account_filter_materialized @@ -4306,7 +4406,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_hogql_person_property_test_account_filter_materialized.1 @@ -4355,7 +4456,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_person_property_test_account_filter @@ -4392,7 +4494,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_person_property_test_account_filter.1 @@ -4441,7 +4544,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_person_property_test_account_filter_materialized @@ -4478,7 +4582,8 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # --- # name: TestSessionRecordingsListFromFilters.test_top_level_person_property_test_account_filter_materialized.1 @@ -4527,6 +4632,7 @@ format_csv_allow_double_quotes=0, max_ast_elements=1000000, max_expanded_ast_elements=1000000, - max_query_size=524288 + max_query_size=524288, + max_bytes_before_external_group_by=0 ''' # ---