From 6fa3360faa0daa511976ac717ce4d29dd29d6341 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Far=C3=ADas=20Santana?= <tomas@tomasfarias.dev>
Date: Thu, 21 Mar 2024 16:29:12 +0100
Subject: [PATCH] feat: Frontend support for file_format

---
 .../src/scenes/batch_exports/BatchExportEditForm.tsx     | 9 +++++++++
 .../src/scenes/batch_exports/BatchExports.stories.tsx    | 1 +
 .../src/scenes/batch_exports/batchExportEditLogic.ts     | 1 +
 frontend/src/types.ts                                    | 1 +
 4 files changed, 12 insertions(+)

diff --git a/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx b/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
index b015659cfaef1..a2a9f9968f82c 100644
--- a/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
+++ b/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
@@ -242,6 +242,15 @@ export function BatchExportsEditFields({
                                     ]}
                                 />
                             </LemonField>
+
+                            <LemonField name="file_format" label="Format" className="flex-1">
+                                <LemonSelect
+                                    options={[
+                                        { value: 'JSONLines', label: 'JSON lines' },
+                                        { value: 'Parquet', label: 'Apache Parquet' },
+                                    ]}
+                                />
+                            </LemonField>
                         </div>
 
                         <div className="flex gap-4">
diff --git a/frontend/src/scenes/batch_exports/BatchExports.stories.tsx b/frontend/src/scenes/batch_exports/BatchExports.stories.tsx
index 0dd616c44982a..dbd6779cb208d 100644
--- a/frontend/src/scenes/batch_exports/BatchExports.stories.tsx
+++ b/frontend/src/scenes/batch_exports/BatchExports.stories.tsx
@@ -42,6 +42,7 @@ export default {
                             include_events: [],
                             encryption: null,
                             kms_key_id: null,
+                            file_format: 'JSONLines',
                         },
                     },
                     start_at: null,
diff --git a/frontend/src/scenes/batch_exports/batchExportEditLogic.ts b/frontend/src/scenes/batch_exports/batchExportEditLogic.ts
index bc86d1618fe4f..30c123256d81a 100644
--- a/frontend/src/scenes/batch_exports/batchExportEditLogic.ts
+++ b/frontend/src/scenes/batch_exports/batchExportEditLogic.ts
@@ -90,6 +90,7 @@ export const batchExportFormFields = (
                   aws_secret_access_key: isNew ? (!config.aws_secret_access_key ? 'This field is required' : '') : '',
                   compression: '',
                   encryption: '',
+                  file_format: isNew ? (!config.file_format ? 'This field is required' : '') : '',
                   kms_key_id: !config.kms_key_id && config.encryption == 'aws:kms' ? 'This field is required' : '',
                   exclude_events: '',
                   include_events: '',
diff --git a/frontend/src/types.ts b/frontend/src/types.ts
index be96494253ae8..58f54b786a7df 100644
--- a/frontend/src/types.ts
+++ b/frontend/src/types.ts
@@ -3597,6 +3597,7 @@ export type BatchExportDestinationS3 = {
         encryption: string | null
         kms_key_id: string | null
         endpoint_url: string | null
+        file_format: string
     }
 }