From 592fe456d61c3a4c14131d257db86268a4547949 Mon Sep 17 00:00:00 2001 From: Ben White Date: Thu, 23 Nov 2023 16:17:19 +0100 Subject: [PATCH] Fixed up when it gets shown --- .../sidepanel/SidePanel.stories.tsx | 40 ++++++++++++++++++- .../sidepanel/sidePanelLogic.tsx | 8 +++- frontend/src/lib/constants.tsx | 1 + 3 files changed, 46 insertions(+), 3 deletions(-) diff --git a/frontend/src/layout/navigation-3000/sidepanel/SidePanel.stories.tsx b/frontend/src/layout/navigation-3000/sidepanel/SidePanel.stories.tsx index cafeef755592b..0b89e9cd7ae62 100644 --- a/frontend/src/layout/navigation-3000/sidepanel/SidePanel.stories.tsx +++ b/frontend/src/layout/navigation-3000/sidepanel/SidePanel.stories.tsx @@ -1,5 +1,15 @@ import { Meta, StoryFn } from '@storybook/react' +import { useActions } from 'kea' +import { router } from 'kea-router' +import { FEATURE_FLAGS } from 'lib/constants' +import { useEffect } from 'react' import { App } from 'scenes/App' +import { urls } from 'scenes/urls' + +import { setFeatureFlags } from '~/mocks/browser' +import { SidePanelTab } from '~/types' + +import { sidePanelStateLogic } from './sidePanelStateLogic' const meta: Meta = { title: 'Scenes-App/SidePanels', @@ -10,6 +20,34 @@ const meta: Meta = { }, } export default meta -export const SidePanelDocs: StoryFn = () => { + +const BaseTemplate = (props: { panel: SidePanelTab }): JSX.Element => { + const { openSidePanel } = useActions(sidePanelStateLogic) + setFeatureFlags([FEATURE_FLAGS.POSTHOG_3000]) + useEffect(() => { + router.actions.push(urls.dashboards()) + openSidePanel(props.panel) + }, []) + return } + +export const SidePanelDocs: StoryFn = () => { + return +} + +export const SidePanelWelcome: StoryFn = () => { + return +} + +export const SidePanelSettings: StoryFn = () => { + return +} + +export const SidePanelActivation: StoryFn = () => { + return +} + +export const SidePanelNotebooks: StoryFn = () => { + return +} diff --git a/frontend/src/layout/navigation-3000/sidepanel/sidePanelLogic.tsx b/frontend/src/layout/navigation-3000/sidepanel/sidePanelLogic.tsx index c32a0ed12d23e..d0d96441377a5 100644 --- a/frontend/src/layout/navigation-3000/sidepanel/sidePanelLogic.tsx +++ b/frontend/src/layout/navigation-3000/sidepanel/sidePanelLogic.tsx @@ -1,4 +1,4 @@ -import { actions, afterMount, connect, kea, path, reducers, selectors } from 'kea' +import { afterMount, connect, kea, path, reducers, selectors } from 'kea' import { activationLogic } from 'lib/components/ActivationSidebar/activationLogic' import { FEATURE_FLAGS } from 'lib/constants' import { featureFlagLogic } from 'lib/logic/featureFlagLogic' @@ -37,7 +37,11 @@ export const sidePanelLogic = kea([ shouldShowWelcomeAnnouncement: [ (s) => [s.welcomeAnnouncementAcknowledged, s.featureFlags], (welcomeAnnouncementAcknowledged, featureFlags) => { - if (featureFlags[FEATURE_FLAGS.POSTHOG_3000] && !welcomeAnnouncementAcknowledged) { + if ( + featureFlags[FEATURE_FLAGS.POSTHOG_3000] && + featureFlags[FEATURE_FLAGS.POSTHOG_3000_WELCOME_ANNOUNCEMENT] && + !welcomeAnnouncementAcknowledged + ) { return true } diff --git a/frontend/src/lib/constants.tsx b/frontend/src/lib/constants.tsx index e49b8f3f9387b..c9828c3296cad 100644 --- a/frontend/src/lib/constants.tsx +++ b/frontend/src/lib/constants.tsx @@ -140,6 +140,7 @@ export const FEATURE_FLAGS = { QUERY_ASYNC: 'query-async', // owner: @webjunkie POSTHOG_3000: 'posthog-3000', // owner: @Twixes POSTHOG_3000_NAV: 'posthog-3000-nav', // owner: @Twixes + POSTHOG_3000_WELCOME_ANNOUNCEMENT: 'posthog-3000-welcome-announcement', // owner: #posthog-3000 ENABLE_PROMPTS: 'enable-prompts', // owner: @lharries FEEDBACK_SCENE: 'feedback-scene', // owner: @lharries NOTEBOOKS: 'notebooks', // owner: #team-monitoring