diff --git a/cypress/e2e/persons.cy.ts b/cypress/e2e/persons.cy.ts index ee57d75d066ac..2a7d81510b628 100644 --- a/cypress/e2e/persons.cy.ts +++ b/cypress/e2e/persons.cy.ts @@ -4,7 +4,7 @@ describe('Persons', () => { }) it('All tabs work', () => { - cy.get('h1').should('contain', 'People') + cy.get('h1').should('contain', 'Persons') cy.get('[data-attr=persons-search]').type('marisol').type('{enter}').should('have.value', 'marisol') cy.wait(200) cy.get('[data-row-key]').its('length').should('be.gte', 0) diff --git a/frontend/__snapshots__/scenes-app-persons-groups--cohorts--dark.png b/frontend/__snapshots__/scenes-app-persons-groups--cohorts--dark.png index 2b513355fd164..7f3c76e76f834 100644 Binary files a/frontend/__snapshots__/scenes-app-persons-groups--cohorts--dark.png and b/frontend/__snapshots__/scenes-app-persons-groups--cohorts--dark.png differ diff --git a/frontend/__snapshots__/scenes-app-persons-groups--cohorts--light.png b/frontend/__snapshots__/scenes-app-persons-groups--cohorts--light.png index 785f6e01082a6..7f52fbd252e93 100644 Binary files a/frontend/__snapshots__/scenes-app-persons-groups--cohorts--light.png and b/frontend/__snapshots__/scenes-app-persons-groups--cohorts--light.png differ diff --git a/frontend/__snapshots__/scenes-app-persons-groups--groups--dark.png b/frontend/__snapshots__/scenes-app-persons-groups--groups--dark.png index 471e5028d4096..6f9e746e34fe0 100644 Binary files a/frontend/__snapshots__/scenes-app-persons-groups--groups--dark.png and b/frontend/__snapshots__/scenes-app-persons-groups--groups--dark.png differ diff --git a/frontend/__snapshots__/scenes-app-persons-groups--groups--light.png b/frontend/__snapshots__/scenes-app-persons-groups--groups--light.png index f91446985036a..d8c1aa57a79ad 100644 Binary files a/frontend/__snapshots__/scenes-app-persons-groups--groups--light.png and b/frontend/__snapshots__/scenes-app-persons-groups--groups--light.png differ diff --git a/frontend/__snapshots__/scenes-app-persons-groups--persons--dark.png b/frontend/__snapshots__/scenes-app-persons-groups--persons--dark.png index a30eac7b66913..a813549b3e852 100644 Binary files a/frontend/__snapshots__/scenes-app-persons-groups--persons--dark.png and b/frontend/__snapshots__/scenes-app-persons-groups--persons--dark.png differ diff --git a/frontend/__snapshots__/scenes-app-persons-groups--persons--light.png b/frontend/__snapshots__/scenes-app-persons-groups--persons--light.png index eeae899249b91..cb9ecfb568b3d 100644 Binary files a/frontend/__snapshots__/scenes-app-persons-groups--persons--light.png and b/frontend/__snapshots__/scenes-app-persons-groups--persons--light.png differ diff --git a/frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx b/frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx index fb030cb8976c2..f284a44625c58 100644 --- a/frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx +++ b/frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx @@ -20,8 +20,7 @@ interface LabelType { const labels: Record = { person: { label: 'persons', - description: - 'Search by email or Distinct ID. Email will match partially, for example: "@gmail.com". Distinct ID needs to match exactly.', + description: 'Search by name, email, Person ID or Distinct ID.', }, group: { label: 'groups', diff --git a/frontend/src/scenes/persons-management/PersonsManagementScene.tsx b/frontend/src/scenes/persons-management/PersonsManagementScene.tsx index 3300b21824954..099fef0f60217 100644 --- a/frontend/src/scenes/persons-management/PersonsManagementScene.tsx +++ b/frontend/src/scenes/persons-management/PersonsManagementScene.tsx @@ -21,9 +21,11 @@ export function PersonsManagementScene(): JSX.Element { return ( <> diff --git a/frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx b/frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx index c96a9718057e5..32534ae82c10a 100644 --- a/frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx +++ b/frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx @@ -52,7 +52,7 @@ export const personsManagementSceneLogic = kea( { key: 'persons', url: urls.persons(), - label: 'People & groups', + label: 'Persons', content: , }, { diff --git a/frontend/src/scenes/persons/PersonsSearch.tsx b/frontend/src/scenes/persons/PersonsSearch.tsx deleted file mode 100644 index f532154a9bb2c..0000000000000 --- a/frontend/src/scenes/persons/PersonsSearch.tsx +++ /dev/null @@ -1,47 +0,0 @@ -import { IconInfo } from '@posthog/icons' -import { LemonInput } from '@posthog/lemon-ui' -import { useActions, useValues } from 'kea' -import { Tooltip } from 'lib/lemon-ui/Tooltip' -import { useEffect, useState } from 'react' -import { useDebouncedCallback } from 'use-debounce' - -import { personsLogic } from './personsLogic' - -export const PersonsSearch = (): JSX.Element => { - const { loadPersons, setListFilters } = useActions(personsLogic) - const { listFilters } = useValues(personsLogic) - const [searchTerm, setSearchTerm] = useState('') - - const loadPersonsDebounced = useDebouncedCallback(loadPersons, 800) - - useEffect(() => { - setSearchTerm(listFilters.search || '') - }, []) - - useEffect(() => { - setListFilters({ search: searchTerm || undefined }) - loadPersonsDebounced() - }, [searchTerm]) - - return ( -
- - - Search by email or Distinct ID. Email will match partially, for example: "@gmail.com". Distinct - ID needs to match exactly. - - } - > - - -
- ) -}