From 3783b68af2d46b6d6e5bb833ecb5ae9e0c2f2f18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Obermu=CC=88ller?= Date: Fri, 22 Dec 2023 17:59:48 +0100 Subject: [PATCH] fix missing occurances --- .../src/layout/navigation/SideBar/SideBar.tsx | 26 +++++++++---------- .../src/layout/navigation/TopBar/TopBar.tsx | 2 +- .../src/scenes/dashboard/DashboardHeader.tsx | 17 +++++------- 3 files changed, 20 insertions(+), 25 deletions(-) diff --git a/frontend/src/layout/navigation/SideBar/SideBar.tsx b/frontend/src/layout/navigation/SideBar/SideBar.tsx index c8811625e90a09..ea86f54352865e 100644 --- a/frontend/src/layout/navigation/SideBar/SideBar.tsx +++ b/frontend/src/layout/navigation/SideBar/SideBar.tsx @@ -150,20 +150,18 @@ function Pages(): JSX.Element { }, }} /> - - } - identifier={Scene.Notebooks} - to={urls.notebooks()} - sideAction={{ - icon: , - to: urls.notebook('new'), - tooltip: 'New notebook', - identifier: Scene.Notebook, - onClick: hideSideBarMobile, - }} - /> - + } + identifier={Scene.Notebooks} + to={urls.notebooks()} + sideAction={{ + icon: , + to: urls.notebook('new'), + tooltip: 'New notebook', + identifier: Scene.Notebook, + onClick: hideSideBarMobile, + }} + /> } identifier={Scene.SavedInsights} diff --git a/frontend/src/layout/navigation/TopBar/TopBar.tsx b/frontend/src/layout/navigation/TopBar/TopBar.tsx index e3f5b78828c2b9..cf9f4125dcdb4f 100644 --- a/frontend/src/layout/navigation/TopBar/TopBar.tsx +++ b/frontend/src/layout/navigation/TopBar/TopBar.tsx @@ -85,7 +85,7 @@ export function TopBar(): JSX.Element { url={`${window.location.origin}${window.POSTHOG_APP_CONTEXT.year_in_hog_url}`} /> )} - {hasNotebooks && } + ) : ( diff --git a/frontend/src/scenes/dashboard/DashboardHeader.tsx b/frontend/src/scenes/dashboard/DashboardHeader.tsx index f45401afd372a8..f8725e7693b201 100644 --- a/frontend/src/scenes/dashboard/DashboardHeader.tsx +++ b/frontend/src/scenes/dashboard/DashboardHeader.tsx @@ -3,7 +3,6 @@ import { router } from 'kea-router' import { TextCardModal } from 'lib/components/Cards/TextCard/TextCardModal' import { EditableField } from 'lib/components/EditableField/EditableField' import { ExportButton, ExportButtonItem } from 'lib/components/ExportButton/ExportButton' -import { FlaggedFeature } from 'lib/components/FlaggedFeature' import { FullScreen } from 'lib/components/FullScreen' import { ObjectTags } from 'lib/components/ObjectTags/ObjectTags' import { PageHeader } from 'lib/components/PageHeader' @@ -266,15 +265,13 @@ export function DashboardHeader(): JSX.Element | null { > Duplicate dashboard - - createNotebookFromDashboard(dashboard)} - status="stealth" - fullWidth - > - Create notebook from dashboard - - + createNotebookFromDashboard(dashboard)} + status="stealth" + fullWidth + > + Create notebook from dashboard + {canEditDashboard && ( {