From 22fba03a211f9db7bbaefeb80fdf6ddcb729a16c Mon Sep 17 00:00:00 2001 From: Anirudh Pillai Date: Thu, 18 Jul 2024 20:23:09 +0100 Subject: [PATCH] Fix type check --- .../AnnotationsOverlay/AnnotationsOverlay.tsx | 1 + .../AnnotationsOverlay/annotationsOverlayLogic.ts | 12 ++++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/frontend/src/lib/components/AnnotationsOverlay/AnnotationsOverlay.tsx b/frontend/src/lib/components/AnnotationsOverlay/AnnotationsOverlay.tsx index 309e41ea157e5..6490d22cbe370 100644 --- a/frontend/src/lib/components/AnnotationsOverlay/AnnotationsOverlay.tsx +++ b/frontend/src/lib/components/AnnotationsOverlay/AnnotationsOverlay.tsx @@ -62,6 +62,7 @@ export function AnnotationsOverlay({ const annotationsOverlayLogicProps: AnnotationsOverlayLogicProps = { ...insightProps, + dashboardId: insightProps.dashboardId, insightNumericId, dates, ticks: chart.scales.x.ticks, diff --git a/frontend/src/lib/components/AnnotationsOverlay/annotationsOverlayLogic.ts b/frontend/src/lib/components/AnnotationsOverlay/annotationsOverlayLogic.ts index 279b7422a9741..c866d6a5febae 100644 --- a/frontend/src/lib/components/AnnotationsOverlay/annotationsOverlayLogic.ts +++ b/frontend/src/lib/components/AnnotationsOverlay/annotationsOverlayLogic.ts @@ -7,11 +7,19 @@ import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic' import { teamLogic } from 'scenes/teamLogic' import { AnnotationDataWithoutInsight, annotationsModel } from '~/models/annotationsModel' -import { AnnotationScope, DatedAnnotationType, InsightLogicProps, InsightModel, IntervalType } from '~/types' +import { + AnnotationScope, + DashboardType, + DatedAnnotationType, + InsightLogicProps, + InsightModel, + IntervalType, +} from '~/types' import type { annotationsOverlayLogicType } from './annotationsOverlayLogicType' -export interface AnnotationsOverlayLogicProps extends InsightLogicProps { +export interface AnnotationsOverlayLogicProps extends Omit { + dashboardId: DashboardType['id'] | undefined insightNumericId: InsightModel['id'] | 'new' dates: string[] ticks: Tick[]