From 217b3658504c858a9f62606e8fa24921ecaf8662 Mon Sep 17 00:00:00 2001
From: David Newell <d.newell1@outlook.com>
Date: Tue, 21 Nov 2023 09:45:56 +0000
Subject: [PATCH] fix: use default color icon 3000 (#18721)

---
 frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss    | 6 ------
 .../src/lib/lemon-ui/LemonButton/LemonButton3000.scss     | 4 +---
 .../src/lib/lemon-ui/LemonButton/LemonButtonLegacy.scss   | 8 ++++++++
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss b/frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss
index 6422a901239ff..7190ef5c1b0d4 100644
--- a/frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss
+++ b/frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss
@@ -137,12 +137,6 @@
 
     @each $status in ('primary', 'danger', 'primary-alt', 'muted') {
         &.LemonButton--status-#{$status} {
-            color: var(--#{$status}-3000, var(--#{$status}, var(--primary)));
-
-            .LemonButton__icon {
-                color: var(--#{$status}-3000, var(--#{$status}));
-            }
-
             // Primary - blocked color style
             &.LemonButton--primary {
                 color: #fff;
diff --git a/frontend/src/lib/lemon-ui/LemonButton/LemonButton3000.scss b/frontend/src/lib/lemon-ui/LemonButton/LemonButton3000.scss
index e0067bc5406af..9e7f178d442bf 100644
--- a/frontend/src/lib/lemon-ui/LemonButton/LemonButton3000.scss
+++ b/frontend/src/lib/lemon-ui/LemonButton/LemonButton3000.scss
@@ -35,9 +35,7 @@
             padding: 0.25rem 0.75rem;
             width: 100%;
 
-            .LemonButton__icon:first-child {
-                transition: var(--transition);
-                color: var(--default);
+            .LemonButton__icon {
                 opacity: 0.5;
             }
         }
diff --git a/frontend/src/lib/lemon-ui/LemonButton/LemonButtonLegacy.scss b/frontend/src/lib/lemon-ui/LemonButton/LemonButtonLegacy.scss
index fc10519414fee..abe0e6cc3e802 100644
--- a/frontend/src/lib/lemon-ui/LemonButton/LemonButtonLegacy.scss
+++ b/frontend/src/lib/lemon-ui/LemonButton/LemonButtonLegacy.scss
@@ -124,6 +124,12 @@ body:not(.posthog-3000) {
                     background: var(--#{$status}-highlight, var(--primary-highlight));
                 }
 
+                color: var(--#{$status}-3000, var(--#{$status}, var(--primary)));
+
+                .LemonButton__icon {
+                    color: var(--#{$status}-3000, var(--#{$status}));
+                }
+
                 &:not([aria-disabled='true']):active {
                     color: var(--#{$status}-dark, var(--primary-dark));
 
@@ -134,6 +140,8 @@ body:not(.posthog-3000) {
 
                 // Primary - blocked color style
                 &.LemonButton--primary {
+                    color: #fff;
+
                     .LemonButton__icon {
                         color: #fff;
                     }