diff --git a/ee/api/dashboard_collaborator.py b/ee/api/dashboard_collaborator.py index 0e070f0c2860c..998eeba8238f9 100644 --- a/ee/api/dashboard_collaborator.py +++ b/ee/api/dashboard_collaborator.py @@ -88,7 +88,7 @@ class DashboardCollaboratorViewSet( mixins.DestroyModelMixin, viewsets.GenericViewSet, ): - scope_object = "INTERNAL" + scope_object = "dashboard" permission_classes = [CanEditDashboardCollaborator] pagination_class = None queryset = DashboardPrivilege.objects.select_related("dashboard").filter(user__is_active=True) diff --git a/frontend/src/lib/components/ActivityLog/__mocks__/activityLogMocks.ts b/frontend/src/lib/components/ActivityLog/__mocks__/activityLogMocks.ts index 1727f0ed6bb8c..3026aa131089a 100644 --- a/frontend/src/lib/components/ActivityLog/__mocks__/activityLogMocks.ts +++ b/frontend/src/lib/components/ActivityLog/__mocks__/activityLogMocks.ts @@ -3,6 +3,36 @@ import { ActivityLogItem } from 'lib/components/ActivityLog/humanizeActivity' import { ActivityScope, InsightShortId } from '~/types' export const teamActivityResponseJson: ActivityLogItem[] = [ + { + user: { + first_name: 'sdavasdadadsadas', + last_name: '', + email: 'paul@posthog.com', + }, + unread: false, + is_staff: false, + is_system: false, + activity: 'updated', + item_id: '1', + scope: ActivityScope.TEAM, + detail: { + name: 'Default Project', + type: undefined, + merge: null, + changes: [ + { + type: ActivityScope.TEAM, + after: { poe_v2_enabled: true }, + field: 'extra_settings', + action: 'created', + before: null, + }, + ], + trigger: null, + short_id: null, + }, + created_at: '2024-02-08T19:23:53.530402Z', + }, { user: { first_name: 'sdavasdadadsadas', diff --git a/frontend/src/lib/components/DefinitionPopover/DefinitionPopoverContents.tsx b/frontend/src/lib/components/DefinitionPopover/DefinitionPopoverContents.tsx index e174b688a36f6..1c9e4928ecb22 100644 --- a/frontend/src/lib/components/DefinitionPopover/DefinitionPopoverContents.tsx +++ b/frontend/src/lib/components/DefinitionPopover/DefinitionPopoverContents.tsx @@ -293,7 +293,18 @@ function DefinitionView({ group }: { group: TaxonomicFilterGroup }): JSX.Element onChange={(value) => setLocalDefinition({ id_field: value })} /> -