Don't wait for migrations for capture pods #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankh
force-pushed
the
frank/dont-wait-migration-capture
branch
from
b099962 to
6c1bbaf
Compare
xvello
approved these changes
Oct 18, 2023
frankh
force-pushed
the
frank/dont-wait-migration-capture
branch
3 times, most recently
from
ca12609 to
b5c9b8b
Compare
xvello
approved these changes
Oct 19, 2023
charts/posthog/values.yaml
Outdated
| @@ -16,7 +16,7 @@ image: | |||
| # -- PostHog image tag to use (example: `release-1.43.0`). | |||
| tag: | |||
| # -- PostHog default image. Do not overwrite, use `image.sha` or `image.tag` instead. | |||
| default: ":release-1.43.0" | |||
| default: ":latest" | |||
There was a problem hiding this comment.
we have stopped pushing lastest, let's use master here?
There was a problem hiding this comment.
this is posthog/posthog, where we push latest but not master by the looks of it https://hub.docker.com/r/posthog/posthog/tags?page=1&name=master
frankh
force-pushed
the
frank/dont-wait-migration-capture
branch
from
0d9f643 to
c9599c5
Compare
These pods don't care about migrations and waiting for them slows down scaling and deployments
frankh
force-pushed
the
frank/dont-wait-migration-capture
branch
from
b88940a to
5edcfe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These pods don't care about migrations and waiting for them slows down scaling and deployments
Type of change
How has this been tested?
Checklist