Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back FromPyObject implementations for structs wrapping &str references once the second lifetime is added to the trait in pyo3 #1850

Open
ljeub-pometry opened this issue Nov 6, 2024 · 0 comments

Comments

@ljeub-pometry
Copy link
Collaborator

With the Bound changes in pyo3, it is currently no longer possible to get a &str reference with a named lifetime in FromPyObject implementations which means we had to introduce a bunch of extra wrapper structs to deal with this. Once PyO3/pyo3#4390 is merged and released, we should remove those again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant