Allow a manual target to be set #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the ability to set a manual target that the tooltip should be anchored to. A test is added to ensure that the target can be set manually and that the tooltip is updated appropriately to be anchored correctly.
|
@bicknellr dang it, I can't add source: hooli like i used to be able to. but just pretend ;). |
|
It'd be nice if the target isn't limited to siblings or direct parent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to set a manual target that the tooltip
should be anchored to. A test is added to ensure that the target can be
set manually and that the tooltip is updated appropriately to be
anchored correctly.
Fixes #144