Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Add property label to improve application binding #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

btopro
Copy link

@btopro btopro commented Aug 7, 2017

There's currently no way to update the label on the element without destroying the contents of the element or creating a new "label" element outside of the toggle. By providing a label attribute you would be able to listen to change events on the toggle and then update the label to match the new state. Would also fix #106 or at least provide a way of supporting it.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@btopro
Copy link
Author

btopro commented Aug 7, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to change the innerHtml/content?
2 participants