Added wrapper function for mouseover, mouseenter, and mouseleave #92
Conversation
…), and mouseover(node, xy) that wrap the makeMouseEvent(eventName, xy, node) function. Wrote unit test for the new functions.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
I give my consent.
…On Thu, Dec 21, 2017 at 3:56 PM, googlebot ***@***.***> wrote:
So there's good news and bad news.
👍 The good news is that everyone that needs to sign a CLA (the pull
request submitter and all commit authors) have done so. Everything is all
good there.
😕 The bad news is that it appears that one or more commits were authored
by someone other than the pull request submitter. We need to confirm that
all authors are ok with their commits being contributed to this project.
Please have them confirm that here in the pull request.
*Note to project maintainer: This is a terminal state, meaning the
cla/google commit status will not change from this State. It's up to you to
confirm consent of the commit author(s) and merge this pull request when
appropriate.*
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWToOSzdhq_4CUunYa4jhQ4TR59ULtBFks5tCtQUgaJpZM4RKZrq>
.
|
There was a problem hiding this comment.
mouseenter and mouseleave have a "complex" behavior (see comments), this should probably be handled here.
Also, what about mouseout? https://developer.mozilla.org/en-US/docs/Web/Events/mouseout
| @@ -1,2 +1,3 @@ | |||
| bower_components* | |||
| bower-*.json | |||
| .idea/ | |||
| } | ||
|
|
||
| /** | ||
| * Fires a `mouseenter` mouse event on a specific node, at a given set of coordinates. |
There was a problem hiding this comment.
should be "Fires a mouseover mouse event" here
| /** | ||
| /** | ||
| * Fires a `mouseenter` mouse event on a specific node, at a given set of coordinates. | ||
| * This event bubbles and is cancellable. If the (x,y) coordinates are |
There was a problem hiding this comment.
mouseenter doesn't bubble and is not cancellable.
Also, it should fire a separate event for each parent up to <body> - see https://developer.mozilla.org/en-US/docs/Web/Events/mouseenter. Do we expect this to be done here or by the user?
|
|
||
| /** | ||
| * Fires a `mouseleave` mouse event on a specific node, at a given set of coordinates. | ||
| * This event bubbles and is cancellable. If the (x,y) coordinates are |
There was a problem hiding this comment.
Similarly to mouseenter, mouseleave doesn't bubble and is not cancellable.
Also, it should fire a separate event for each parent up to <body> - see https://developer.mozilla.org/en-US/docs/Web/Events/mouseleave. Do we expect this to be done here or by the user?
Fixes #90, fixes #65 by creating three new functions mouseenter(node, xy), mouseleave(node, xy), and mouseover(node, xy) that wrap the makeMouseEvent(eventName, xy, node) function.