Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

No updated tag since before splitHtml refactor #75

Open
jsilvermist opened this issue May 25, 2017 · 4 comments
Open

No updated tag since before splitHtml refactor #75

jsilvermist opened this issue May 25, 2017 · 4 comments

Comments

@jsilvermist
Copy link

@abdonrd @FredKSchott The latest tag for this is 2.0.1, which as @johnlim noted in #74 doesn't contain any of the updated syntax as long ago as the splitHtml refactor from PolymerProject to polymer-build.

This should be tagged with the current commits, as well as probably updating the polymer-starter-kit submodule commit, as this is still pointing to a commit from January 9th.

@FredKSchott
Copy link
Contributor

Good catch, I'll create a new release

@FredKSchott
Copy link
Contributor

released as v2.1.0, anything else needed for psk?

@jsilvermist
Copy link
Author

jsilvermist commented May 25, 2017

@FredKSchott Well the commit it's pulling in for the psk is only missing several cleanups compared to the latest tagged version, but the PSK for Polymer 1 itself hasn't been tagged since before updating dependencies, and renaming sourceGlobs and includeDependencies to sources and extraDependencies.

(Full diff of current commit custom-build is pointing to vs master)

Also, the submodule linking to the psk would need to be updated to point to the latest release by:

$ cd generators/app/polymer-starter-kit/
$ git checkout <commit>
$ cd ..
$ git commit -v polymer-starter-kit/

Note: I can send a PR to update the submodule to a new commit if you don't want to checkout these repos, just tell me which commit to point it to. (Maybe tagging a new PSK 2,x release)

@abdonrd
Copy link
Member

abdonrd commented Jun 12, 2017

We probably update the Custom Build after Polymer/polymer-starter-kit#1035.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants