Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

[support] .gitignore in 1.0.0 (PSK2)? #27

Open
ElijahLynn opened this issue Aug 29, 2016 · 6 comments
Open

[support] .gitignore in 1.0.0 (PSK2)? #27

ElijahLynn opened this issue Aug 29, 2016 · 6 comments
Labels

Comments

@ElijahLynn
Copy link

New to Polymer here. I used polymer init custom-build and I did not get a resulting .gitignore file that excluded /bower and /node_modules. I do see that I am using 1.0.0 of custom-build which points to the 2.0 tag of the Polymer Starter Kit. That tag does have the correct .gitignore file.

Why do I not automatically get the .gitignore in PSK 2.0?

ElijahLynn added a commit to ElijahLynn/www.elijahlynn.net that referenced this issue Aug 29, 2016
@ElijahLynn
Copy link
Author

Actually, it seems as if maybe it was intentional not to ship with a .gitignore since many will want to have their own overrides to that.

Even so I think maybe a .gitignore-suggested would be good if that's the case. Some confirmation on this would still be awesome!

ElijahLynn added a commit to ElijahLynn/www.elijahlynn.net that referenced this issue Aug 29, 2016
@chuckh chuckh added the bug label Aug 30, 2016
@chuckh
Copy link
Contributor

chuckh commented Aug 30, 2016

This is not intentional. For some reason Polymer CLI is not copying it. PSK2 has .gitignore included.

.gitignore (should include at least these lines)

bower_components/
build/
node_modules/

@ElijahLynn
Copy link
Author

I wonder if we should move this to https://github.com/Polymer/polymer-cli.

Also, I am using v0.16.0 of polymer-cli.

@robdodson
Copy link
Contributor

It may be related to this: https://github.com/yeoman/generator-polymer/blob/master/app/index.js#L60

I think when you npm install something with a .gitignore it renames it to .npmignore. Need to double check that's the case.

@chuckh
Copy link
Contributor

chuckh commented Sep 1, 2016

It is still related to npm bug that renames .gitignore to .npmignore. See below.

image

@stramel
Copy link
Contributor

stramel commented Nov 2, 2016

As @robdodson was saying .gitignore does get renamed to .npmignore. There is a good conversation here npm/npm#7252 but ultimately would need a work around from the sounds of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants