Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polymer-build remove comments #3471

Open
ghost opened this issue Nov 8, 2019 · 3 comments
Open

polymer-build remove comments #3471

ghost opened this issue Nov 8, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 8, 2019

Currently the polymer build tool leaves all comments in. If the user specifies js: minify, I believe comments should be removed. This could be achieved here:

const result = babelCore.transformFromAst(ast, js, {presets, plugins});

by passing {presets, plugins, comments: false}

@jonapgar
Copy link

jonapgar commented Jan 3, 2020

"minify"

@stale
Copy link

stale bot commented Jan 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 2, 2021
@quackbarc
Copy link

Even supplying bundle.stripComments on polymer.json doesn't actually strip comments away, at least on Polymer 1.0 projects. It's driving me nuts.

@stale stale bot removed the wontfix label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants