Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"use strict" at the top of the output file breaks any non-strict code #1859

Closed
davidgiven opened this issue Feb 13, 2016 · 1 comment
Closed

Comments

@davidgiven
Copy link

...such as web-animations-next.min.js, which is used by Polymer's Neon. The minifier it's been built with is generating non-strict code (specifically, it's assuming that 'this' points at window by default):

web-animations/web-animations-next#402

This specific case is obviously a configuration issue at web-animations' end, but there's plenty of non-strict code floating around the net and putting "use strict" at the top of the output file means that it can't be used by vulcanize. There should be an option to disable this.

@davidgiven
Copy link
Author

Oops. Sorry, my mistake --- the line's been added by babelify, not vulcanize (I'm running babelify after vulcanize). Nothing to do with Polymer. Apologies for the noise.

@aomarks aomarks transferred this issue from Polymer/polymer-bundler Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants