Vulcanize mangles javascript code containing -->

[zboralski]

After running vulcanize on elements.html which imports an element containing:

<script language="JavaScript" type="text/javascript" src="../../bower_components/jsrsasign/jsrsasign-latest-all-min.js"></script>

if (f-- > 0)

is changed to

if (f--\x3e0)

and causing polyclean to choke :
googlearchive/polybuild#27

[zboralski]

The problem is that any occurrence of -->0 will be rewritten by vulcanize as --\x3e0..

I replace all -->0 to -- > 0 and it solved the problem with polybuild, chrome, etc...

[zboralski]

Note that the original file jsbn.js used (f-- > 0) but when it was minified into the jsrsasign components... it was simplified to (f-->0)

[mm-gmbd]

+1, thanks for figuring this out @zboralski!!

[garlicnation]

@azakus Could this be caused by the included uglify change?

[dfreedm]

Possibly. --inline-script will try to escape </script> https://github.com/Polymer/vulcanize/blob/master/third_party/UglifyJS2/output.js#L55-L57

[halkar]

+1 thanks @zboralski

[d1manson]

Thanks for figuring this out. I encountered this problem with --> in a js comment (I was using it as an arrow).

[rbellens]

I don't know in which cases script tags should be escaped, but turning it off in
https://github.com/Polymer/polymer-bundler/blob/master/src/import-utils.ts#L209
fixes the issue. Is it safe or will it break some other use cases?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.