Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering: TimeSystem is not consts correct for RenderingDevice #139

Open
sp0lsh opened this issue Jun 30, 2018 · 0 comments
Open

Rendering: TimeSystem is not consts correct for RenderingDevice #139

sp0lsh opened this issue Jun 30, 2018 · 0 comments
Labels

Comments

@sp0lsh
Copy link
Contributor

sp0lsh commented Jun 30, 2018

class ENGINE_DLLEXPORT IRenderingDevice : public BaseObject<>
{
    public:
   ...
        virtual void RenderWorld(World* world) = 0;
};

This is our current IRenderingDevice interaface for engine. I we want to make const World* world in virtual void RenderWorld(World* world) = 0; it requiere us to make const correct time retrieval from TimeSystem.

Now when we add cost to world the refactoring changes have dependencies in TimeSystem that influence UpdatePhase.

Anyways there should be also SystemTime in ex. nanosecond that is flowing, available during rendering. It would allow for simplest profiling.

@sp0lsh sp0lsh changed the title TimeSystem is not consts correct for RenderingDevice Rendering: TimeSystem is not consts correct for RenderingDevice Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants