Configure Storybook for Orderbook Component Testing #1346
Conversation
WalkthroughThe recent updates introduce Storybook configuration for the Changes
Sequence Diagram(s)No sequence diagrams are generated as the changes are predominantly configuration-based and do not modify control flow. Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
❌ Deploy Preview for stupendous-valkyrie-505e4a failed. Why did it fail? →
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
apps/hestia/package.jsonis excluded by!**/*.jsonapps/hestia/public/logo.svgis excluded by!**/*.svg,!**/*.svgyarn.lockis excluded by!**/yarn.lock,!**/*.lock,!**/*.lock
Files selected for processing (6)
- apps/hestia/.gitignore (1 hunks)
- apps/hestia/.storybook/main.ts (1 hunks)
- apps/hestia/.storybook/manager.ts (1 hunks)
- apps/hestia/.storybook/preview.tsx (1 hunks)
- apps/hestia/.storybook/theme.ts (1 hunks)
- apps/hestia/src/components/accessDenied/template.stories.ts (1 hunks)
Files skipped from review due to trivial changes (3)
- apps/hestia/.gitignore
- apps/hestia/.storybook/manager.ts
- apps/hestia/src/components/accessDenied/template.stories.ts
Additional comments not posted (9)
apps/hestia/.storybook/theme.ts (3)
1-3: Verify necessity of@ts-ignore.The
@ts-ignorecomment might be suppressing a TypeScript error. Ensure that this is necessary and consider resolving the underlying issue if possible.
1-4: LGTM!The import statements are correct and necessary.
5-23: LGTM!The theme configuration is correctly set up with appropriate properties for colors, backgrounds, and brand details.
apps/hestia/.storybook/preview.tsx (3)
1-5: LGTM!The import statements are correct and necessary.
7-10: LGTM!The font configuration is correctly set up with appropriate weights and subsets.
12-31: LGTM!The preview configuration is correctly set up with appropriate parameters for actions and controls, and a decorator for applying the font.
apps/hestia/.storybook/main.ts (3)
1-4: LGTM!The import statements are correct and necessary.
5-11: LGTM!The utility function
getAbsolutePathis correctly implemented and follows best practices.
12-32: LGTM!The Storybook configuration is correctly set up with appropriate stories, addons, framework, and static directories.
minikas
changed the title
Description
This pull request sets up Storybook for testing Orderbook components and pages.
Changes Made:
Screenshots / Screencasts
Checklist
Close: #1345