-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to output ParameterNode as YAML #295
Draft
SylviaDu99
wants to merge
15
commits into
PolicyEngine:master
Choose a base branch
from
SylviaDu99:parameternode-274
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1939220
feat: add `write_yaml` method in `parameter_node.py` to output the no…
SylviaDu99 d9a37d5
fix: modified `write_yaml` method in `parameter_node.py` to output th…
SylviaDu99 56582af
chore: fix format
SylviaDu99 5e8bc8b
Update changelog_entry.yaml
SylviaDu99 b9352b1
Merge branch 'PolicyEngine:master' into parameternode-274
SylviaDu99 a0a6bfa
test: Add sample data
anth-volk ab9a573
Merge branch 'PolicyEngine:master' into parameternode-274
SylviaDu99 4fb27f8
feat: add function in AtInstantLike to return desired attributes in d…
SylviaDu99 5c26564
Merge branch 'PolicyEngine:master' into parameternode-274
SylviaDu99 b4731ec
feat: simplified function in AtInstantLike to return desired attribut…
SylviaDu99 01ef1a3
Merge branch 'PolicyEngine:master' into parameternode-274
SylviaDu99 eaceba1
feat: add get_attr_dict function in both super class and all subclasses
SylviaDu99 a38dafa
Merge branch 'PolicyEngine:master' into parameternode-274
SylviaDu99 731c921
minor: set sort_keys to false when output to yaml file to make it mor…
SylviaDu99 ffb84a7
minor: use OrderedDict in `get_attr_dict` functions to provide more r…
SylviaDu99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
- bump: minor | ||
changes: | ||
added: | ||
- write_yaml function to output ParameterNode data to a YAML file | ||
- test_write_yaml test to produce a sample output |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best practice here would be to keep this method as simple as possible, then do a bit more work with it where we actually use it. What I would do here is:
I wouldn't recurse downward here, either. I think we can do that inside our custom
ParameterNode
method, where we're more broadly defining what we're doing.