Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simulation.subsample #279

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Add Simulation.subsample #279

merged 6 commits into from
Sep 24, 2024

Conversation

nikhilwoodruff
Copy link
Contributor

Fixes #278

@nikhilwoodruff nikhilwoodruff added the enhancement New feature or request label Sep 24, 2024
@nikhilwoodruff nikhilwoodruff self-assigned this Sep 24, 2024
@nikhilwoodruff nikhilwoodruff changed the title Update documentation Add Simulation.subsample Sep 24, 2024
@nikhilwoodruff nikhilwoodruff marked this pull request as draft September 24, 2024 17:26
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 8.57143% with 32 lines in your changes missing coverage. Please review.

Project coverage is 79.51%. Comparing base (cf53c6d) to head (8bfcd1a).

Files with missing lines Patch % Lines
policyengine_core/simulations/simulation.py 8.57% 31 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   79.73%   79.51%   -0.23%     
==========================================
  Files         192      192              
  Lines       10057    10088      +31     
  Branches     1311     1317       +6     
==========================================
+ Hits         8019     8021       +2     
- Misses       1753     1781      +28     
- Partials      285      286       +1     
Flag Coverage Δ
79.51% <8.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikhilwoodruff
Copy link
Contributor Author

The Windows failure is a documentation failure which isn't critical, so merging.

@nikhilwoodruff nikhilwoodruff marked this pull request as ready for review September 24, 2024 18:10
@nikhilwoodruff nikhilwoodruff merged commit 60d589a into master Sep 24, 2024
3 of 4 checks passed
@nikhilwoodruff nikhilwoodruff deleted the subsample branch September 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add quantisation
1 participant