fix: accessible colors and set up more neutrals #93
Conversation
also referenced in tailwind config
accessibility
|
@joshuagraber it may be bad form to add all those neutral variants we aren't using yet, LMK and I will stash them somewhere. I do want to incorporate this soon, but I want that exercise to stop slowing down the gold accessibility thing |
|
@josh-chamberlain I don't think it's bad form. This looks good, and it'll be nice to have the full range of options available. Do you think we can merge this to |
joshuagraber
changed the title
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9480360 | Triggered | Generic Password | 5db616b | src/components/Form/form.spec.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
🎉 This PR is included in version 3.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes
fixes #92
Description
I've been playing with these colors and being indecisive, so I figured it was time to just submit a small PR that fixes the accessibility and play with things later.
goldandwinewhere 500 is the original hex value50and950are not pure black or white, just closegoldneutralandwineneutralto the playground, but nothing is using them yet50and950are not pure black or white, just closeneutralwithgoldneutralorwineneutralin the config often looks very nice, but can be weirdblueout of thebrandsection out of pure pedantry (it's not a brand color)