-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
punionWith flips arguments #556
Comments
This is horrible @blamario |
I'm not sure the code will still work if you change that snippet, but we could keep track of flipping to flip application to the combine function if necessary. |
Yup it's bad, sorry. I wouldn't just flip there because of accumulating flip applications. |
Brian Kush just noted that (obviously) |
Are these two extra functions necessary? I'm not sure |
I found the following inputs to
punionWith
which seem to flip the order of the arguments.It turns out that
punionWith (-)
, ends up calling this code which does appear to flip arguments:plutarch-plutus/Plutarch/Api/V1/AssocMap.hs
Line 395 in 77bbe60
The fix could be to declare that
punionWith
is to be used with commutative operations only, or it could be thatpunionWith
needs to stop flipping arguments. In any case, I'd be thankful for any hints on howpunionWith
is expected to work.The text was updated successfully, but these errors were encountered: