Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat messages broken when ItemsAdder is installed #3397

Open
5 tasks done
Llopeando opened this issue Feb 4, 2024 · 6 comments
Open
5 tasks done

Chat messages broken when ItemsAdder is installed #3397

Llopeando opened this issue Feb 4, 2024 · 6 comments
Labels
compat: plugin Compatibility with another Spigot plugin outdated: plugin The plugin is outdated. outdated: server The server is outdated. status: inactive This issue is inactive. type: bug Something isn't working

Comments

@Llopeando
Copy link

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

No response

What happened?

Hi there!
In our server we are using ItemsAdder and VentureChat, and after installing ItemsAdder (configuring self host and all of that), the chat just broke down, as you can see in the image at the bottom of the report.

Steps to reproduce the issue

  1. Install VentureChat
  2. Install ItemsAdder
  3. The chat messages will broke down. (/msg commands and so on will work perfectly fine)

Server version

This server is running Paper version git-Paper-318 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 9271ee7)
You are running the latest version

ItemsAdder Version

ItemsAdder version 3.6.3-beta-11

ProtocolLib Version

ProtocolLib version 5.2.0-SNAPSHOT-679

LoneLibs Version

LoneLibs version 1.0.45

FULL server log

Full server log: https://mcpaste.io/a143d5c336d29dc2

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

imagen

@Llopeando Llopeando added the type: bug Something isn't working label Feb 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

Hello,
your report will be looked into as soon as possible.
Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

@Llopeando
Copy link
Author

It seems to be the "font_images" and "text-effects" settings for the chat, which if they are enabled, they will break the chat.
I will leave the issue open, if you think that this is an actual bug or not.

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Feb 5, 2024

I think it's an issue of VentureChat to be honest, as EssentialsX chat and similar works fine.
I will do some testing in the next days to make sure.

@LoneDev6 LoneDev6 added this to the 3.6.3-beta-13 milestone Feb 5, 2024
@LoneDev6 LoneDev6 added the compat: plugin Compatibility with another Spigot plugin label Feb 5, 2024
@LoneDev6 LoneDev6 moved this to Todo in ItemsAdder Feb 5, 2024
@GsTio86
Copy link

GsTio86 commented Feb 15, 2024

I also encountered the same problem, but after I turned off font_images and text-effects, everything worked fine

@LoneDev6
Copy link
Collaborator

Chat code is currently overcomplicated and very hard to maintain due to the fact that I want to have both Spigot and Paper compatibility.
In a future update I will drop Spigot compatibility for font images and font effects in chat due to the fact that no one is using Spigot.
Professional servers are using Paper due to its extensibility, feature rich API and performance improvements.
This will allow me to easily fix this kind of issues, hopefully.

Sources:
https://bstats.org/global/bukkit
Image

@LoneDev6 LoneDev6 modified the milestones: 3.6.3-beta-14, future-update Apr 24, 2024
@madebygood
Copy link

Please solve it

@LoneDev6 LoneDev6 moved this from Todo to Stalled in ItemsAdder Jun 13, 2024
@LoneDev6 LoneDev6 added status: inactive This issue is inactive. outdated: plugin The plugin is outdated. labels Jun 13, 2024
@LoneDev6 LoneDev6 removed this from the future-update milestone Jun 13, 2024
@LoneDev6 LoneDev6 added the outdated: server The server is outdated. label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat: plugin Compatibility with another Spigot plugin outdated: plugin The plugin is outdated. outdated: server The server is outdated. status: inactive This issue is inactive. type: bug Something isn't working
Projects
Status: Stalled
Development

No branches or pull requests

4 participants