Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render ModelEngine Balloons #239

Closed
4 tasks done
PanHaskins opened this issue Jun 14, 2024 · 4 comments
Closed
4 tasks done

Render ModelEngine Balloons #239

PanHaskins opened this issue Jun 14, 2024 · 4 comments
Labels
compat: plugin Compatibility with another Spigot plugin type: bug Something isn't working type: other plugin bug This is another plugin bug.

Comments

@PanHaskins
Copy link

PanHaskins commented Jun 14, 2024

Terms

  • I'm using the very latest version of CosmeticsCore and its dependencies.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

panhaskins

What happened?

Problem with balloon rendering. As you can see in the video, the balloon is really only displayed for a very short distance (a couple of blocks).

This happens when I have a server view-distance of 5 and a simulation distance of 4-6.

It's so weird, since modelengine shows the other models from mythicmobs etc correctly as it does in the video, only the balloons don't. Due to this, the modelengine may be lagging probably because it's somehow working badly with their API and it's throwing "invisible" errores and only Spark is catching it. But that may just be my guess.

Steps to reproduce the issue

  1. Add CosmeticsCore and MEG 4
  2. Set view-distance to 5 and simulation-distance to 4
  3. Log on and equipt any type MEG balloon

Server version

git-Purpur-2176 (MC: 1.20.4)

CosmeticsCore Version

CosmeticsCore 1.2.3d

ProtocolLib Version

ProtocolLib 5.2.0-SNAPSHOT-679

LoneLibs Version

LoneLibs 1.0.45

FULL server log

Any errors

Error (optional)

No response

CosmeticsCore config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

2024-06-14.18-20-10.mp4

image

@PanHaskins PanHaskins added the type: bug Something isn't working label Jun 14, 2024
@LoneDev6
Copy link
Contributor

This probably has to do with MEG api itself.
Anyway please provide your report URL and the MEG version.

@LoneDev6 LoneDev6 moved this to Need answer in Other plugins Jun 26, 2024
@LoneDev6 LoneDev6 added compat: plugin Compatibility with another Spigot plugin type: other plugin bug This is another plugin bug. labels Jun 26, 2024
@PanHaskins
Copy link
Author

ModelEngine R4.0.6.1
and I'd rather send you a spark report privately.

@SrMonsterYT
Copy link

SrMonsterYT commented Aug 2, 2024

same problem here: https://youtu.be/K2ATErblMak

server: git-Pufferfish-47 MC: 1.20.4
CosmeticsCore_1.3.0-release-1
ModelEngine-4.0.6.1
ProtocolLib 5.3.0-SNAPSHOT-699
LoneLibs 1.0.54

@LoneDev6
Copy link
Contributor

LoneDev6 commented Sep 3, 2024

@PanHaskins
This is my code, anyway I think it's an issue of MEG not my plugin.

        ModelBlueprint blueprint = ModelEngineAPI.getBlueprint(customEntityKey);
        megModel = ModelEngineAPI.createActiveModel(blueprint);

        fakeMegEntity = new Dummy();
        fakeMegEntity.setLocation(loc);
        megEntity = ModelEngineAPI.createModeledEntity(fakeMegEntity);

        if (megEntity == null)
        {
            Msg.error("Failed to spawn custom entity '" + customEntityKey + "'! megEntity is null.");
            return;
        }

        megEntity.addModel(megModel, false);
        megEntity.setBaseEntityVisible(false);
        fakeMegEntity.setRenderRadius(loc.getWorld().getViewDistance());

@LoneDev6 LoneDev6 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
@LoneDev6 LoneDev6 moved this from Need answer to Stalled in Other plugins Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat: plugin Compatibility with another Spigot plugin type: bug Something isn't working type: other plugin bug This is another plugin bug.
Projects
Status: Stalled
Development

No branches or pull requests

3 participants