Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't exit from wardrobe on server 1.20.2 and latest devbuild of ProtocolLib #198

Closed
4 tasks done
EpicPlayerA10 opened this issue Dec 30, 2023 · 5 comments
Closed
4 tasks done
Labels
type: other plugin bug This is another plugin bug. verdict: invalid This issue is not precise and lacks proper information to be worked on.

Comments

@EpicPlayerA10
Copy link

Terms

  • I'm using the very latest version of CosmeticsCore and its dependencies.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

epicplayera10

What happened?

I set up a Paper server on 1.20.2 with CosmeticsCore. When I entered to the wardrobe and I tried to exit it using shift key, then I can't. It does nothing.

I discovered that when I downgrade the ProtocolLib to dev build 673 then the problem disappears. The problem appear on the latest dev build of ProtocolLib.

Steps to reproduce the issue

  1. Setup a Paper server on 1.20.2
  2. Install CosmeticsCore, latest devbuild of ProtocolLib and LoneLibs
  3. Enter to the wardrobe
  4. Try to exit it using shift key.
  5. See that you can't

Server version

This server is running Paper version git-Paper-318 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 9271ee7)

CosmeticsCore Version

CosmeticsCore version 1.2.3b

ProtocolLib Version

ProtocolLib version 5.2.0-SNAPSHOT-679

LoneLibs Version

LoneLibs version 1.0.42

FULL server log

No response

Error (optional)

No response

CosmeticsCore config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

@EpicPlayerA10 EpicPlayerA10 added the type: bug Something isn't working label Dec 30, 2023
@LoneDev6
Copy link
Contributor

Are you 100% sure it's caused by the latest version of ProtocoLib or was it just a coincidence?

@LoneDev6 LoneDev6 moved this to Need answer in Other plugins Jan 29, 2024
@LoneDev6 LoneDev6 added the verdict: can't reproduce This issue cannot be reproduced by the developers label Jan 29, 2024
@EpicPlayerA10
Copy link
Author

I think this bug occurs because of the fact that the latest dev build of ProtocolLib is only for 1.20.4 and not for 1.20.2. Downgrading ProtocolLib to version that it supports 1.20.2 works fine. I think I can close this issue now.

@LoneDev6 LoneDev6 reopened this Feb 20, 2024
@LoneDev6 LoneDev6 removed the verdict: can't reproduce This issue cannot be reproduced by the developers label Feb 20, 2024
@LoneDev6
Copy link
Contributor

Thanks, will be checked, I need to find what changed between these ProtocolLib builds.

@Kosoca
Copy link

Kosoca commented Feb 20, 2024

I may have found the solution (for my part it works) You must ensure that the entrance to the wardrobe is not on the same path as the exit, otherwise the player will be directly teleported back

@LoneDev6
Copy link
Contributor

Seems a bug of ProtocolLib 5.2.0-SNAPSHOT-679 and 1.20.2.
For some reason PacketType.Play.Client.STEER_VEHICLE.getPacketClass() returns ServerboundPongPacket instead of PacketPlayInSteerVehicle.
Opened a new report here: dmulloy2/ProtocolLib#2818

@LoneDev6 LoneDev6 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
@LoneDev6 LoneDev6 added type: other plugin bug This is another plugin bug. and removed type: bug Something isn't working labels Feb 26, 2024
@LoneDev6 LoneDev6 removed the status in Other plugins Feb 26, 2024
@LoneDev6 LoneDev6 removed this from the 1.2.3c milestone Feb 26, 2024
@LoneDev6 LoneDev6 added the verdict: invalid This issue is not precise and lacks proper information to be worked on. label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: other plugin bug This is another plugin bug. verdict: invalid This issue is not precise and lacks proper information to be worked on.
Projects
Status: No status
Development

No branches or pull requests

3 participants