Optimization

[Lerphie]

Terms

• I'm using the very latest version of CosmeticsCore and its dependencies.
• I already searched on this Github page to check if the same issue was already reported.
• I already searched on the plugin wiki to know if a solution is already known.
• I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

Coder#6926

What happened?

I have a large server with over 300 people playing on it. When the players accumulate, your plugin causes a heavy load on the server processor.

https://spark.lucko.me/n0wU4PFcJ3

Steps to reproduce the issue

Server version

This server is running GuardSpigot 1.16.5 version git-Airplane-"e37fa86" (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)

CosmeticsCore Version

ProtocolLib Version

LoneLibs Version

FULL server log

No response

Error (optional)

No response

CosmeticsCore config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

https://spark.lucko.me/n0wU4PFcJ3

Screenshots/Videos (you can drag and drop files or paste links)

https://spark.lucko.me/n0wU4PFcJ3

[Lerphie]

The load is higher

25ms for main thread tasks

35ms for parse packet and then forward into protocollib and then into plugins

Please LoneDev! I really love your plugins, we need your optimization
Mostly the problem appears when many players are crowded into one chunk

[LoneDev6]

TPS is 20, it's not causing excessive CPU load.

The plugin is coded with performance in mind, and was tested extensively on a server with more than 200 players moving around with cosmetics.

Did you experience any slowdown or the only alarming detail was the timings report orange ms indicators?

Anyway tomorrow I'll do a detailed check to see if the function you reported can be further optimized.

[Lerphie]

TPS is 20, it's not causing excessive CPU load.

The plugin is coded with performance in mind, and was tested extensively on a server with more than 200 players moving around with cosmetics.

Did you experience any slowdown or the only alarming detail was the timings report orange ms indicators?

Anyway tomorrow I'll do a detailed check to see if the function you reported can be further optimized.

What does this have to do with tps? Your plugin is putting a lot of strain on my system. It happens only on spawning (when players get very close to each other). In addition, the server begins to lag very much within those chunks where there are many players

[LoneDev6]

What does this have to do with tps?

Well, TPS is the main thing you have to check to see if a server is performant or not.

the server begins to lag very much within those chunks where there are many players

Provide a timings report of when the lag occurs.

[Lerphie]

What does this have to do with tps?

Well, TPS is the main thing you have to check to see if a server is performant or not.

the server begins to lag very much within those chunks where there are many players

Provide a timings report of when the lag occurs.

You're wrong. I'd like to send you a video of the proof. How can I do it privately so others can't see it?

[LoneDev6]

Make a "payment issue" private ticket on my forum https://forum.devs.beer/

[LoneDev6]

Update to DEV builds of Via
https://ci.viaversion.com/job/ViaVersion-DEV/
https://ci.viaversion.com/view/ViaBackwards/job/ViaBackwards-DEV/

I think the lag is caused by ViaVersion printing too many error messages.

[LoneDev6]

Anyway analyzing the timings report I found out that you have some plugin that is refreshing the player inventory a lot.
This causes the CosmeticsCore hat reskin code to be called a lot of times.
This code has a part which reskins the read helmet to have the custom helmet skin.

I will do some more tests to see if I can optimize it or I will add an option to skip part of this code.
The heavy part of this code is the lore and display name logic to make it italic, which might sound stupid but I am using the internal game code to do that, so it's a performance problem related to the code of the game itself.

[Lerphie]

Update to DEV builds of Via https://ci.viaversion.com/job/ViaVersion-DEV/ https://ci.viaversion.com/view/ViaBackwards/job/ViaBackwards-DEV/

I think the lag is caused by ViaVersion printing too many error messages.

Unfortunately it's not going to help me. This is a problem of ModelEngine 3 not being compatible with ViaVersion

ViaVersion/ViaVersion#3522 (comment)

[Lerphie]

Anyway analyzing the timings report I found out that you have some plugin that is refreshing the player inventory a lot. This causes the CosmeticsCore hat reskin code to be called a lot of times. This code has a part which reskins the read helmet to have the custom helmet skin.

Maybe the problem is in my plugin. Could you please check it?
joinitems.zip

[Lerphie]

or more likely it's the HuskSync plugin, it synchronizes the player's inventory (including what he's wearing on his head).

https://www.spigotmc.org/resources/husksync-1-16-1-20-sync-inventories-e-chests-x-server-advancements-map-art-stats-backups.97144/

https://github.com/WiIIiam278/HuskSync

[Lerphie]

I found a prioritized configuration, maybe it will help.
https://william278.net/docs/husksync/config-file

[Lerphie]

@LoneDev6 Did you fix it? Have you read my last few posts?

[LoneDev6]

I will do some more tests to see if I can optimize it or I will add an option to skip part of this code.
The heavy part of this code is the lore and display name logic to make it italic, which might sound stupid but I am using the internal game code to do that, so it's a performance problem related to the code of the game itself.

I scheduled it to be fixed, please be patient, I will do my best to finish the upcoming update as soon as possible.

[LoneDev6]

The code reported uses 70% less CPU on the upcoming update.
I will release it as soon as I can.