Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Balloons via ModelEngine 4 #174

Closed
4 tasks done
BendersRepublic opened this issue Nov 6, 2023 · 8 comments
Closed
4 tasks done

Red Balloons via ModelEngine 4 #174

BendersRepublic opened this issue Nov 6, 2023 · 8 comments
Labels
type: bug Something isn't working type: other plugin bug This is another plugin bug. verdict: can't reproduce This issue cannot be reproduced by the developers

Comments

@BendersRepublic
Copy link

Terms

  • I'm using the very latest version of CosmeticsCore and its dependencies.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

PapaWulf#0001

What happened?

I installed ModelEngine v4. Using CosmeticsCore 1.2.3

But for some reason, my balloons are red when they come from cosmeticscore. I tried to enable dye, then set it to white, and nothing happened. Also note that the dyes are originally all disabled on the cosmetics config.

using /meg disguise, my balloons are colored properly

Steps to reproduce the issue

/wardrobe
pick a balloon
see it be red while using modelengine4

Server version

Current: git-Purpur-2044 (MC: 1.20.1)*

CosmeticsCore Version

CosmeticsCore version 1.2.3

ProtocolLib Version

ProtocolLib version 5.1.1-SNAPSHOT-668

LoneLibs Version

LoneLibs version 1.0.27

FULL server log

https://mclo.gs/jG0ILEZ

Error (optional)

No response

CosmeticsCore config.yml

lang: en
extract_default_assets: true
cosmetics:
  max_equippable:
    body: 3
    balloon: 2
wardrobe_room:
  camera:
    hide_actionbar_texts: true
    rotation:
      enabled: true
    zoom:
      enabled: true
      min: 2
    fade_effect: true
    location:
      world: spawn
      x: -54.5
      y: 79.62000000476837
      z: -41.5
      yaw: 0.93607324
      pitch: -7.65004
  mannequin:
    location:
      world: spawn
      x: -54.5
      y: 78.0625
      z: -38.5
      yaw: 179.13638
      pitch: 4.799979
  teleport_area:
    enter:
      world: flat
      pos1:
        x: 167
        y: -61
        z: 42
      pos2:
        x: 167
        y: -57
        z: 37
    exit_location:
      world: spawn
      x: -36.33065831093231
      y: 62.9375
      z: -43.64031086411282
      yaw: -68.06349
      pitch: -7.34998
  gui:
    cursor_default: fermented_spider_eye:9000001
    cursor_rotate: fermented_spider_eye:9000002
    cursor_pointer: fermented_spider_eye:9000003
    dyeing_pointer: fermented_spider_eye:9100003
    tutorial_gui: fermented_spider_eye:9100004
    tutorial_gui_checked: fermented_spider_eye:9100005
    slots:
      colors:
        not_owned: 195,147,57
        owned: 56,67,100
        wearing: 57,70,195
        wearing_preview: 195,120,57
        max_amount_reached: 111,111,111
      add_item_in_blank_slots:
        # This is useful only for some expert users that need to do some crazy stuff.
        # Do not enable it if you don't know what you are doing.
        enabled: false
        type: PAPER
        custom_model_data: 1337666
send_creative_hidden_hat_message: true
save:
  # Use only one at a time
  file:
    enabled: true
  mysql:
    enabled: false
    url: jdbc:mysql://my_url_database_69.com:3306/database_name
    username: username
    password: password
    table: cosmeticscore_saved
debug: false

Problematic items yml configuration file (optional)

cosmetics:
  bs_balloon_bee:
    enabled: true
    display_name: "Bee Balloon"
    type: MEG_BALLOON_ENTITY
    model:
      gui: paper:26
      normal: bs_balloon_bee
    dye:
      enabled: true
      default: "#ffffff"

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

https://i.gyazo.com/thumb/1200/ff02c86ad90400f6bcff4750f908dd20-jpg.jpg

@BendersRepublic BendersRepublic added the type: bug Something isn't working label Nov 6, 2023
@LoneDev6 LoneDev6 moved this to Todo in Other plugins Nov 7, 2023
@LoneDev6 LoneDev6 added this to the 1.2.3-r2 milestone Nov 7, 2023
@leestar960
Copy link

hey?

@LoneDev6
Copy link
Contributor

Will be checked in the next days, thanks for the patience.

@LoneDev6 LoneDev6 moved this from Todo to In Progress in Other plugins Nov 17, 2023
@LoneDev6
Copy link
Contributor

LoneDev6 commented Nov 17, 2023

I cannot reproduce the issue.
There is some info missing about how to trigger this issue.

image
image

cosmetics:

  # Example custom balloon created with ModelEngine entities (supports also animated ModelEngine entities models)
  meg_amogus_balloon:
    enabled: true
    display_name: "Amogus Balloon (MEG)"
    type: MEG_BALLOON_ENTITY
    # Showing a different item into the GUI (in this case it's a must because ModelEngine entities can't be put in GUIs)
    model:
      gui: potion:400014
      normal: amogus
    dye:
      enabled: true
      default: "#ffffff"

@LoneDev6 LoneDev6 removed the status in Other plugins Nov 17, 2023
@LoneDev6 LoneDev6 added the verdict: can't reproduce This issue cannot be reproduced by the developers label Nov 17, 2023
@LoneDev6 LoneDev6 removed this from the 1.2.3-r2 milestone Nov 17, 2023
@LoneDev6 LoneDev6 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2023
@LoneDev6 LoneDev6 added type: other plugin bug This is another plugin bug. status: inactive This issue is inactive. labels Nov 18, 2023
@BendersRepublic
Copy link
Author

2023-11-21.20-33-58.mp4

as you can see in the background, I'm simply clicking. I'm using modelengine 4.0.3, and cosmeticscore 1.2.3

@LoneDev6 LoneDev6 reopened this Nov 22, 2023
@LoneDev6
Copy link
Contributor

LoneDev6 commented Nov 22, 2023

I am using ModelEngine-4.0.2F and CosmeticsCore 1.2.3-r3 and I cannot reproduce the issue.
You could share your modelengine model and the cosmeticscore configuration with me so that I can test directly using your model.

@BendersRepublic
Copy link
Author

hmm, it's happening to all of our models and the configurations are almost identical. I'll do a binary search and get back to you

@BendersRepublic
Copy link
Author

fixed, god damn color codes being enabled at white still made my balloons red I guess, disabling the dye worked properly

@LoneDev6
Copy link
Contributor

fixed, god damn color codes being enabled at white still made my balloons red I guess, disabling the dye worked properly

Can you add more details about what was the cause of the issue? I might have to specify that in the wiki.
Let me know, thanks!

@LoneDev6 LoneDev6 removed the status: inactive This issue is inactive. label Nov 27, 2023
@LoneDev6 LoneDev6 mentioned this issue Jan 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: other plugin bug This is another plugin bug. verdict: can't reproduce This issue cannot be reproduced by the developers
Projects
Status: No status
Development

No branches or pull requests

3 participants