Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.3 still having cosmetics shown at wrong height issue #173

Closed
4 tasks done
Pattanawaris opened this issue Oct 29, 2023 · 17 comments
Closed
4 tasks done

1.2.3 still having cosmetics shown at wrong height issue #173

Pattanawaris opened this issue Oct 29, 2023 · 17 comments
Labels
type: bug Something isn't working
Milestone

Comments

@Pattanawaris
Copy link

Terms

  • I'm using the very latest version of CosmeticsCore and its dependencies.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

No response

What happened?

issue from #168 is still exist in 1.2.3 with all dependencie plugins updated

Steps to reproduce the issue

Wear some cosmetic.
Left Wardrobe.
Change game view mode to third person view.

Server version

git-paper-259

CosmeticsCore Version

1.2.3

ProtocolLib Version

5.1.1 -Snapshot - 673

LoneLibs Version

1.0.27

FULL server log

No response

Error (optional)

No response

CosmeticsCore config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

@Pattanawaris Pattanawaris added the type: bug Something isn't working label Oct 29, 2023
@LoneDev6
Copy link
Contributor

Please refer to the new tutorials
https://cosmeticscore.devs.beer/adding-content/body-cosmetic/static-body-cosmetic#implementing-the-self-models

You have to implement the self model 2, which I implemented to the default pack, you can get it in the default_assets.zip file under the CosmeticsCore folder (delete this file and restart if you can't get the updated one).

@LoneDev6 LoneDev6 added the status: need more info Need more info from the original poster label Oct 29, 2023
@Pattanawaris
Copy link
Author

Yes but, how about If I didnt use Self model method pls?

@LoneDev6
Copy link
Contributor

It should look just fine if you don't use selfmodel, it was tested and working with default items.

@WindUnwaken
Copy link

Related to #172
Steps to reproduce the issue
Wear some cosmetic.
Left Wardrobe.
Change game view mode to third person view.

Wardobe view is different from normal view (global view)

@Pattanawaris
Copy link
Author

It still having issue :( . even in global view other players are saw it displayed at the wrong height too.
image

@Pattanawaris
Copy link
Author

More info: item displayed fine when first loaded(instant after teleported or join) then quickly lifted up to the wrong height one and stay at the wrong height.

@LoneDev6 LoneDev6 moved this to Todo in Other plugins Nov 6, 2023
@LoneDev6 LoneDev6 removed the status: need more info Need more info from the original poster label Nov 6, 2023
@LoneDev6 LoneDev6 added this to the 1.2.3-r2 milestone Nov 6, 2023
@LoneDev6
Copy link
Contributor

I cannot reproduce the issue.
Please provide an example CosmeticsCore yml file and the json models files for normal, self and self2 cosmetics.
Also provide the 3 .bbmodel files.

Minecraft_.1.20.2.-.Multiplayer.3rd-party.Server.2023-11-17.17-28-48.mp4_compressed.mp4

NOTE: do you have any plugin which is adding nametags on top of the player? (as invisible armorstands riding the player)
It might be the issue.

@LoneDev6 LoneDev6 removed this from the 1.2.3-r2 milestone Nov 17, 2023
@LoneDev6 LoneDev6 removed the status in Other plugins Nov 17, 2023
@LoneDev6 LoneDev6 added status: need more info Need more info from the original poster verdict: can't reproduce This issue cannot be reproduced by the developers labels Nov 17, 2023
@LoneDev6 LoneDev6 moved this to In Progress in Other plugins Nov 18, 2023
@LoneDev6 LoneDev6 moved this from In Progress to Stalled in Other plugins Nov 18, 2023
@WindUnwaken
Copy link

https://youtu.be/ZADrU2N9kQs

Please also check normal view

@WindUnwaken
Copy link

image
image
image

Outside the wardrobe, armorstand is on the top of head,
In the wardobe, near the shoulder, maybe also make normal_2?

@WindUnwaken
Copy link

WindUnwaken commented Nov 19, 2023

https://youtu.be/sozM-UXstpQ

This video shows armorstand position.

@iFranticman
Copy link

I'm having the same issues where my cosmetics are higher than normal. Other players can see it just fine but when i go into f5 i see them high. I use only elite creatures and it's on every cosmetic cape.

@LoneDev6
Copy link
Contributor

Please next time post a video to begin with.
I now see that your issue is that the issue is reproducible on viewers of other players.

I will have to fix the Blockbench extension and the plugin too.

@LoneDev6
Copy link
Contributor

It is related to 1.20.2.
I am going to publish a fix today for both bb extension and Spigot plugin.

@LoneDev6 LoneDev6 added this to the 1.2.3-r3 milestone Nov 20, 2023
@LoneDev6 LoneDev6 moved this from Stalled to Done in Other plugins Nov 20, 2023
@LoneDev6 LoneDev6 removed status: need more info Need more info from the original poster verdict: can't reproduce This issue cannot be reproduced by the developers labels Nov 20, 2023
@iFranticman
Copy link

When i updated i got this
[12:51:37 WARN]: [ItemsAdder] Plugin ItemsAdder v3.6.2-beta-r4 generated an exception while executing task 276
java.lang.NullPointerException: Cannot invoke "org.bukkit.command.PluginCommand.setTabCompleter(org.bukkit.command.TabCompleter)
" because the return value of "dev.lone.itemsadder.Main.a(String)" is null
at ia.m.hs.(SourceFile:80) ~[ItemsAdder_3.6.2-beta-r4.jar:?]
at ia.m.G.a(SourceFile:921) ~[ItemsAdder_3.6.2-beta-r4.jar:?]
at org.bukkit.craftbukkit.v1_20_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.20.2.jar:git-Paper-280]
at org.bukkit.craftbukkit.v1_20_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[paper-1.20.2.jar:git-Paper-280]
at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[paper-1.20.2.j
ar:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:840) ~[?:?]

@LoneDev6
Copy link
Contributor

Please do not report multiple issues on other issue pages.
Anyway this is not related to CosmeticsCore, post your complete server log in a new issue report on ItemsAdder Github.
https://github.com/PluginBugs/Issues-ItemsAdder/issues/

@Pattanawaris
Copy link
Author

Pattanawaris commented Nov 24, 2023

I think I'm still having this issue in latest version :(

in wardrobe:
image

outside wardrobe:
image

CONFIG:

squirrel_tail:
enabled: true
display_name: "Squirrel Tail"
type: BODY_ITEM
model:
gui: potion:400008
normal: potion:400008
dye:
enabled: false

@aaa8881
Copy link

aaa8881 commented Apr 5, 2024

I'm still having difficulty to make this one working in 1.20.2+

sorry for ping @LoneDev6 , pinging as it's old thread and you will prob miss it without it.

only self view in 1.20.2+ is the problem.
self and self_2 model are generated based on normal model , and normal_2 model also exists.

unsure if we're generating self_2 model incorrectly.

  1. should self_2 model generated from normal model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants