Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have ObjectiveFunction.x check the resolution of passed-in things #1392

Open
dpanici opened this issue Nov 18, 2024 · 2 comments
Open

Have ObjectiveFunction.x check the resolution of passed-in things #1392

dpanici opened this issue Nov 18, 2024 · 2 comments
Labels
P2 Medium Priority, not urgent but should be on the near-term agend

Comments

@dpanici
Copy link
Collaborator

dpanici commented Nov 18, 2024

DESC/desc/objectives/objective_funs.py

Line 616 in 95612fa

# TODO: also check resolution etc?

this is a potential problem bc if an objective is built with, say an eq with LMN=8 and a coilset, then I pass into x an LMN=10 eq, all the internal indices for ordering x will be wrong.
@dpanici
Copy link
Collaborator Author

dpanici commented Nov 18, 2024 •
edited
Loading

Same for

DESC/desc/optimize/_constraint_wrappers.py

Line 707 in 95612fa

# TODO: also check resolution etc?

@dpanici dpanici added the P2 Medium Priority, not urgent but should be on the near-term agend label Nov 25, 2024
@dpanici
Copy link
Collaborator Author

dpanici commented Nov 25, 2024

Have objective save dict of dimensions it was built for and check against that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Medium Priority, not urgent but should be on the near-term agend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dpanici