Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reassign interceptors during termination #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reassign interceptors during termination #16

wants to merge 1 commit into from

Conversation

tryuan99
Copy link
Collaborator

This PR unassigns the targets and re-assigns a threat's interceptors during agent termination.

@tryuan99
Copy link
Collaborator Author

tryuan99 commented Oct 16, 2024 •
edited
Loading

@daniellovell All agents need to go through the TerminateAgent() function, but somehow, some interceptors aren't being reassigned correctly (even through their targets have been terminated). Do you know why this might be the case?

In this screenshot, some interceptors are assigned to fly towards the origin even though there is another threat in the scene.
Interceptor reassignment

daniellovell
daniellovell requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@daniellovell daniellovell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the trouble is coming from wrong level of abstraction. Should be done in the IADS.cs, which has a IADS::MarkThreatDestroyed method. If its implemented in IADS, we can also make it configurable in a "limited visibility" environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellovell daniellovell daniellovell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tryuan99 @daniellovell