Introduce `dropwizard/metrics` integration test #894

oxkitsune · 2023-11-23T15:33:29Z

No description provided.

github-actions · 2023-11-23T15:34:59Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie

Try to make sure it runs for Java 11 and 17. We discussed this offline :).

Some comments but in general this looks really nice!

integration-tests/metrics-v4.2.19.sh

integration-tests/integration-test.sh

rickie · 2023-11-26T14:46:35Z

integration-tests/metrics-v4.2.19-expected-changes.patch

+     private String username = "";
+     private String password = "";
+-    private Set<MetricAttribute> disabledMetricAttributes = Collections.emptySet();
+    private Set<MetricAttribute> disabledMetricAttributes = emptySet();


Interesting, are we not rewriting this to ImmutableSet.of?

CollectorMutability is disabled, because there's a few edge cases iirc. I can supress those edge cases 👍 and re-enable.

rickie · 2023-11-26T14:47:55Z

integration-tests/metrics-v4.2.19-expected-warnings.txt

@@ -0,0 +1,8 @@
+metrics-core/src/main/java/com/codahale/metrics/CsvReporter.java:[382,36] [FormatStringConcatenation] Defer string concatenation to the invoked method
+metrics-graphite/src/main/java/com/codahale/metrics/graphite/GraphiteReporter.java:[429,18] [Slf4jLogStatement] Log statement contains 0 placeholders, but specifies 1 matching argument(s)


Oh nice, this will be interesting to fix upstream! As this is literally a bug!

integration-tests/integration-test.sh

rickie · 2023-11-26T14:51:08Z

(Sorry didn't mean to approve yet 😬.)

github-actions · 2023-11-30T11:09:54Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-12-13T09:48:13Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-12-13T10:34:57Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-12-13T10:49:16Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-01-10T08:47:30Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-01-10T08:47:49Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-01-10T09:12:36Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie

Some comments 😄.

integration-tests/metrics-v4.2.19-init.patch

rickie · 2024-01-10T09:18:54Z

integration-tests/metrics-v4.2.19-init.patch

+                                 <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
+                                 <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
+                             </compilerArgs>
+-                            <annotationProcessorPaths>


It doesn't work if we leave this one here combined with the "append" usage in the other profile?

Leaving this here results in a error: plug-in not found: ErrorProne

rickie · 2024-01-10T09:19:34Z

integration-tests/metrics-v4.2.19-init.patch

+                     <compilerArgs>
+                         <arg>-Xlint:all</arg>
+                         <arg>-XDcompilePolicy=simple</arg>
+-                        <arg>-Xplugin:ErrorProne -XepExcludedPaths:.*/target/generated-sources/.*</arg>


Do we use this? Otherwise I'd say we can leave this untouched to minimize the diff.

Same as above

integration-tests/integration-test.sh

integration-tests/checkstyle-10.12.4.sh

.github/workflows/run-integration-tests.yml

integration-tests/integration-test.sh

integration-tests/metrics-v4.2.19.sh

github-actions · 2024-01-10T10:28:56Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

oxkitsune · 2024-01-11T10:35:27Z

/integration-test

github-actions · 2024-01-11T10:44:41Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-01-11T10:45:24Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-01-11T10:50:47Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-01-24T09:22:44Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-01-24T09:55:18Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie · 2024-01-31T12:34:15Z

Rebased and resolved conflict.

github-actions · 2024-01-31T12:35:39Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-02-13T08:31:53Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-03-20T08:37:16Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2024-03-20T11:04:08Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

sonarcloud · 2024-03-20T11:04:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

oxkitsune · 2024-04-03T08:03:38Z

I'm unable to figure out why the refaster options aren't being used in the metrics integration test.
I've tried JDK11 to JDK21, and the exact options given in #654, but I cannot get the ImmutableSet rules to disable.

github-actions · 2024-11-14T08:35:09Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

sonarcloud · 2024-11-14T08:35:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rickie · 2024-11-18T15:14:12Z

Closing in favor of: #1426.

rickie changed the title ~~Initial metrics integration test~~ Introduce dropwizard/metrics integration test Nov 26, 2023

rickie approved these changes Nov 26, 2023

View reviewed changes

rickie self-requested a review November 26, 2023 14:50

oxkitsune force-pushed the gdejong/metrics-integration-test branch from 0ebea1f to afe7925 Compare December 13, 2023 10:47

oxkitsune force-pushed the gdejong/metrics-integration-test branch from 064a1cb to f16db40 Compare January 10, 2024 08:46

rickie reviewed Jan 10, 2024

View reviewed changes

rickie self-requested a review January 10, 2024 09:25

rickie marked this pull request as ready for review January 10, 2024 09:25

oxkitsune force-pushed the gdejong/metrics-integration-test branch from faea805 to 2ef8268 Compare January 24, 2024 09:21

rickie force-pushed the gdejong/metrics-integration-test branch from 47bbaa7 to 65dbef0 Compare January 31, 2024 12:33

rickie force-pushed the gdejong/metrics-integration-test branch from 65dbef0 to 123c2bd Compare February 13, 2024 08:29

oxkitsune and others added 14 commits March 20, 2024 09:35

suggestions

713853d

apply suggestions in init patch

5825498

trigger integration-test action

97989c6

temporarily remove condition

4dcfb10

disable new checks as they cause errors

79931df

Post-rebase fix

4dafc7e

Rename metrics files to drop the version

dddb602

Style improvements

0417783

Typo

75eb8d2

sync metrics

b9836c6

Only run on GH comment

78cac86

Try to trigger metrics

1ff1d57

Try to run both variants

51ec7bc

Dont analyse generated files

ee00181

oxkitsune force-pushed the gdejong/metrics-integration-test branch from ed7545c to ee00181 Compare March 20, 2024 08:35

oxkitsune added 2 commits March 20, 2024 10:47

Fix metrics init patch

8b4cba4

Try different refaster name patterns

cc69b87

rickie mentioned this pull request Apr 17, 2024

Introduce generic run-integration-test.sh script #1141

Merged

rickie added 2 commits November 14, 2024 09:26

Merge master in this branch

f793c73

Fix missed merge conflicts

1ac65e9

Stephan202 mentioned this pull request Nov 17, 2024

minor: avoid reliance on File.createTempFile implementation detail checkstyle/checkstyle#15935

Closed

rickie mentioned this pull request Nov 18, 2024

Introduce Dropwizard Metrics integration test #1426

Merged

rickie closed this Nov 18, 2024

		@@ -0,0 +1,8 @@
		metrics-core/src/main/java/com/codahale/metrics/CsvReporter.java:[382,36] [FormatStringConcatenation] Defer string concatenation to the invoked method
		metrics-graphite/src/main/java/com/codahale/metrics/graphite/GraphiteReporter.java:[429,18] [Slf4jLogStatement] Log statement contains 0 placeholders, but specifies 1 matching argument(s)

Introduce dropwizard/metrics integration test #894

Introduce dropwizard/metrics integration test #894

Conversation

oxkitsune commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

rickie left a comment

Choose a reason for hiding this comment

rickie Nov 26, 2023

Choose a reason for hiding this comment

oxkitsune Nov 30, 2023

Choose a reason for hiding this comment

rickie Nov 26, 2023

Choose a reason for hiding this comment

rickie commented Nov 26, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

rickie left a comment

Choose a reason for hiding this comment

rickie Jan 10, 2024

Choose a reason for hiding this comment

oxkitsune Jan 11, 2024

Choose a reason for hiding this comment

rickie Jan 10, 2024

Choose a reason for hiding this comment

oxkitsune Jan 11, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2024

oxkitsune commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

github-actions bot commented Jan 11, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

rickie commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

sonarcloud bot commented Mar 20, 2024

Quality Gate passed

oxkitsune commented Apr 3, 2024

github-actions bot commented Nov 14, 2024

sonarcloud bot commented Nov 14, 2024

Quality Gate passed

rickie commented Nov 18, 2024

Introduce `dropwizard/metrics` integration test #894

Introduce `dropwizard/metrics` integration test #894