Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Error Prone 2.35.1 -> 2.36.0 #1429

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

Picnic-DevPla-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
Error Prone (source) minor 2.35.1 -> 2.36.0
Error Prone (source) compile minor 2.35.1 -> 2.36.0

Release Notes

google/error-prone (Error Prone)

v2.36.0: Error Prone 2.36.0

Compare Source

Changes:

  • Add new matcher interfaces to ErrorProneScanner for AST nodes introduced after Java 11 (e5fd194)
  • Fix compatibility with latest JDK 24 EA builds (google/error-prone@d67bc15)
  • Check that --should-stop=ifError=FLOW is set when using the -Xplugin integration (e71db1f)

New checks:

Closed issues: #​4633, #​4646


  • If you want to rebase/retry this PR, check this box

@Picnic-DevPla-Bot
Copy link
Contributor Author

Picnic-DevPla-Bot commented Nov 19, 2024

Suggested commit message:

Upgrade Error Prone 2.35.1 -> 2.36.0 (#1429)

And update the compatibility matrix and its generation script.

See:
- https://github.com/google/error-prone/releases/tag/v2.36.0
- https://github.com/google/error-prone/compare/v2.35.1...v2.36.0
- https://github.com/PicnicSupermarket/error-prone/compare/v2.35.1-picnic-1...v2.36.0-picnic-1

@Stephan202 Stephan202 added this to the 0.20.0 milestone Nov 19, 2024
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit and updated the suggested commit message.

Can generate updated compatibility matrix ~tonight.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member

Can generate updated compatibility matrix ~tonight.

This'll require a change to the script, as the new requirement that the --should-stop=ifError=FLOW flag is specified causes Error Prone 2.36.0 to report an error for all past releases. I'll look into this ~later this week.

@Stephan202
Copy link
Member

Can generate updated compatibility matrix ~tonight.

This'll require a change to the script, as the new requirement that the --should-stop=ifError=FLOW flag is specified causes Error Prone 2.36.0 to report an error for all past releases. I'll look into this ~later this week.

K, pushed a likely fix. Will re-run the script ~tonight.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the compatibility matrix and tweaked the suggested commit message.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Picnic-DevPla-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@rickie rickie force-pushed the renovate/version.error-prone-orig branch from 2f04a24 to 9465f69 Compare December 9, 2024 09:48
Copy link

github-actions bot commented Dec 9, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

sonarcloud bot commented Dec 9, 2024

@Stephan202 Stephan202 merged commit 512a3be into master Dec 9, 2024
16 checks passed
@Stephan202 Stephan202 deleted the renovate/version.error-prone-orig branch December 9, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants