Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PublisherProbeAssertWas{,Not}{Subscribed,Cancelled,Requested} Refaster rules #1423

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

werli
Copy link
Member

@werli werli commented Nov 16, 2024

Another set of trivial Reactor Refaster rules.

Suggested commit message:

Introduce `PublisherProbeAssertWas{,Not}{Subscribed,Cancelled,Requested}` Refaster rules (#1423)

While there, fix a typo in `README.md`.

@werli werli changed the title Introduce PublisherProbeAssertWas{,Not}{Subscribed,Cancelled,Requested}} Refaster rules Introduce PublisherProbeAssertWas{,Not}{Subscribed,Cancelled,Requested} Refaster rules Nov 16, 2024
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@werli werli force-pushed the werli/mono-publisher-probes branch from 250de00 to 4e21e01 Compare November 16, 2024 12:53
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 changed the title Introduce PublisherProbeAssertWas{,Not}{Subscribed,Cancelled,Requested} Refaster rules Introduce PublisherProbeAssertWas{,Not}{Subscribed,Cancelled,Requested} Refaster rules Nov 17, 2024
@Stephan202 Stephan202 added this to the 0.20.0 milestone Nov 17, 2024
@Stephan202 Stephan202 requested a review from rickie November 17, 2024 17:56
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the suggested commit message. Tnx @werli!

@@ -217,7 +217,7 @@ Other highly relevant commands:
- `mvn fmt:format` formats the code using
[`google-java-format`][google-java-format].
- [`./run-full-build.sh`][script-run-full-build] builds the project twice,
where the second pass validates compatbility with Picnic's [Error Prone
where the second pass validates compatibility with Picnic's [Error Prone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rickie rickie force-pushed the werli/mono-publisher-probes branch from 4e21e01 to d00d4d5 Compare December 9, 2024 12:34
Copy link

github-actions bot commented Dec 9, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

sonarcloud bot commented Dec 9, 2024

@rickie rickie merged commit 2eda393 into master Dec 9, 2024
16 checks passed
@rickie rickie deleted the werli/mono-publisher-probes branch December 9, 2024 13:25
@werli
Copy link
Member Author

werli commented Dec 9, 2024

Thx @rickie 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants