Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cmake functions for testing with YAML files upstream #62

Open
destogl opened this issue Sep 6, 2022 · 0 comments
Open

Move cmake functions for testing with YAML files upstream #62

destogl opened this issue Sep 6, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@destogl
Copy link
Contributor

destogl commented Sep 6, 2022

The methods from #57 should be moved into corresponding upstream repositories:

  • ament_cmake_gtest
  • ament_cmake_gmock

Should this be add_rostest_with_parameters_gtest or something to make it clear that the input yaml is for parameters and that these are a ros-test in that they only work if your test has ros in it (rclcpp::init(argc, argv);)?

Originally posted by @tylerjw in #57 (comment)

@tylerjw tylerjw added the enhancement New feature or request label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants