Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting power fails @ 100% #1

Open
Wobbly74 opened this issue Jul 4, 2023 · 3 comments
Open

Setting power fails @ 100% #1

Wobbly74 opened this issue Jul 4, 2023 · 3 comments

Comments

@Wobbly74
Copy link

Wobbly74 commented Jul 4, 2023

In the development branch, when using elements which end up with various fractional percentages of the overall power this sometimes ends up with not being able to set the power to 100%, due to the precision of using a float for the calculation. This is easily replicated when setting up 2 elements, one with 3000w the other with 1500w. This ends up with a final powersum array value of 99.999999999 which causes the searchsorted function call in calculate_individual_actor_power to fail with an index out of range when trying to set the power to 100. I've worked around this simply at the moment by just always overriding the last powersum array element to always be 100. Apart from that the newer version of the plugin seems to work ok at first test, as I want to use this plugin to restrict the number of elements used when reaching a boil.

@avollkopf
Copy link
Member

The development branch is not maintained, since I detected plenty of issues with the last tests one year ago and basically nobody was using it. Currently, there are no resources for further development. We need volunteers :-)

@Wobbly74
Copy link
Author

Wobbly74 commented Jul 6, 2023 via email

@avollkopf
Copy link
Member

Not really, since it's about a year ago and nobody really tested it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants