Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making static::unitNameOfAliasesAlreadyRegistered optional depending on environment #75

Open
vasily-kartashov opened this issue Nov 6, 2017 · 0 comments

Comments

@vasily-kartashov
Copy link

vasily-kartashov commented Nov 6, 2017

Can you think of the best way to make the uniqueness test in AbstractPhysicalQuantity::addUnit:24 optional? Profiling says this is by far the slowest part of the library. It's a great feature for development environment, but there's little reason to incur this penalty in production environment, especially with a proper CI set up.

Same applies for HasSIUnitsTrait::addMissingSIPrefixUnits:191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant