Use http4s.Uri in Http4sClient #3215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @igor-vovk |
lenguyenthanh
force-pushed
the
user-http4s-uri-for-http4s-client
branch
2 times, most recently
from
6eb16b6
to
9b855fc
Compare
This is to avoid conversion between ElasticNodeEndpoint to http4s.Uri for every request. Which'll save us some allocation, hence more performance. This also allows users to pass http4s.Uri directly to Http4sClient.
igor-vovk
reviewed
Nov 17, 2024
elastic4s-client-http4s/src/main/scala/com/sksamuel/elastic4s/http4s/Http4sClient.scala
Outdated
Show resolved
Hide resolved
lenguyenthanh
force-pushed
the
user-http4s-uri-for-http4s-client
branch
from
9b855fc
to
eaae78b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid conversion between ElasticNodeEndpoint to http4s.Uri
for every request. Which'll save us some allocation, hence more
performance. This also allows users to pass http4s.Uri directly to
Http4sClient.