Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is the source code for performHpoOboQc? #1

Open
matentzn opened this issue Oct 9, 2023 · 5 comments
Open

Where is the source code for performHpoOboQc? #1

matentzn opened this issue Oct 9, 2023 · 5 comments

Comments

@matentzn
Copy link

matentzn commented Oct 9, 2023

https://github.com/Phenomics/hpo-build-jars/blob/master/performHpoOboQc.jar

@drseb

@drseb
Copy link
Member

drseb commented Oct 9, 2023

In a separate and currently private repo. Why?

@matentzn
Copy link
Author

matentzn commented Oct 9, 2023

I need to change one test regarding synonyms - basically allowing one term to have an exact synonym X and another to have a related synonym X which seems to be super often in the behaviour phenotype space

@drseb
Copy link
Member

drseb commented Oct 9, 2023

I think you need to ignore the jar then - this code is totally obsolete now :-( and can't really be changed anymore. It was written many years ago and uses deprecated APIs

@drseb
Copy link
Member

drseb commented Oct 9, 2023

ignore = throw it out of the process

@matentzn
Copy link
Author

matentzn commented Oct 9, 2023

hmm, I did think that there were a number of useful things still caught by this, but ok! I will keep an eye open what else it fails at, and then make sure the checks are replaced in ROBOT/ODK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants