added proptest & impl Arbitrary traits for quote #2

Leechael · 2024-10-18T14:47:47Z

Added the Arbitrary trait to each Quote struct to simplify mocking and testing.

kvinwang · 2024-10-25T01:04:30Z

src/quote.rs

@@ -36,13 +51,89 @@ pub struct Header {
    pub user_data: [u8; 20],
 }

-#[derive(Decode, Debug)]
+impl Arbitrary for Header {


Code readability suffers when implementing traits manually like this, and it's error-prone. Consider using #[derive(Arbitrary)] instead.

kvinwang · 2024-10-25T01:08:11Z

src/quote.rs

+    T: Encode + TryFrom<usize>,
+    <T as TryFrom<usize>>::Error: std::fmt::Debug,
+{
+    fn encode(&self) -> Vec<u8> {


Prefer implementing fn encode_to rather than fn encode to avoid one extra heap allocation + data copying.

kvinwang · 2024-10-25T01:08:54Z

src/quote.rs

@@ -181,6 +529,16 @@ impl Decode for AuthDataV4 {
    }
 }

+impl Encode for AuthDataV4 {
+    fn encode(&self) -> Vec<u8> {


Prefer encode_to

kvinwang · 2024-10-25T01:09:49Z

tests/encode_quote.rs

+        let mut encoded = vec![];
+        header.encode_to(&mut encoded);


Suggested change

let mut encoded = vec![];

header.encode_to(&mut encoded);

let encoded = header.encode();

added proptest & impl Arbitrary traits for quote

01b0e75

Leechael force-pushed the feat-arbitrary branch from 2c5f157 to 01b0e75 Compare October 18, 2024 14:50

fix: attestation_key_type is an enum

1132078

kvinwang reviewed Oct 25, 2024

View reviewed changes

Provide feedback