Add wasm support for both web and node environment #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolak
changed the title
kvinwang
requested changes
Oct 15, 2024
Cargo.toml
Outdated
Comment on lines
48
to
51
| getrandom = { version = "0.2", features = ["js"] } | ||
| serde-wasm-bindgen = "0.4" | ||
| wasm-bindgen = "0.2.95" | ||
| serde_bytes = "0.11" |
There was a problem hiding this comment.
Let's make them optional and enable them by the feature js.
| pub struct VerifiedReport { | ||
| pub status: String, | ||
| pub advisory_ids: Vec<String>, | ||
| pub report: Report, | ||
| } | ||
|
|
||
| #[wasm_bindgen] |
There was a problem hiding this comment.
Suggested change
| #[wasm_bindgen] | |
| #[cfg(feature = "js")] | |
| #[wasm_bindgen] |
AFAIK, the reqwest supports running in browser. Is there any problem to export the |
kvinwang
approved these changes
Oct 17, 2024
|
Here are the changes to reviewed comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is going to adding wasm support for both web and node envrionment by compile the library to
wasm-unknow-unknowntarget.Note that
jsfeature should be enabled and due to tls not been supportted by WASM,get_collateralwill be disabled at the time