Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPath and // instead of / #1443

Open
gcelano opened this issue Jun 6, 2023 · 3 comments
Open

XPath and // instead of / #1443

gcelano opened this issue Jun 6, 2023 · 3 comments

Comments

@gcelano
Copy link

gcelano commented Jun 6, 2023

The following files have // instead of a / in the last part of their XPath (in <cRefPattern>):

tlg0015.tlg001.1st1K-grc1.xml
tlg5026.tlg007.1st1K-grc1.xml
tlg5026.tlg001.1st1K-grc1.xml

Since the number of elements returned by both XPath expressions (with / and //) is the same, I think that // is a mistake.

@lcerrato
Copy link
Collaborator

lcerrato commented Jun 6, 2023

@gcelano

This is the wrong repo for this report.

There is much inconsistency in refsDecl throughout all collections in this representation as the earlier recommendations evolved. As we review headers for consistency we try to make these corrections.

I see this right now in https://github.com/PerseusDL/canonical-greekLit/blob/master/data/tlg0012/tlg001/tlg0012.tlg001.perseus-grc2.xml for instance.

@gcelano
Copy link
Author

gcelano commented Jun 6, 2023

Some // make a difference, but I would always recommend for / because of consistency. According to my counts. only 123 files have the // issue

@lcerrato
Copy link
Collaborator

lcerrato commented Jun 8, 2023

@gcelano
I would recommend PRs dedicated to this in the appropriate repos if it needs to be addressed short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants