-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wording of "MIT (X11)" is misleading #63
Comments
Yeah that sounds like the best approach to me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The MIT license-related text this module generates seems to misrepresent the variant of that license it actually uses. Software::License::MIT names itself "The MIT (X11) License" in output, but I do not think this is accurate.
According to Wikipedia, the MIT license has two significant variants, largely known as "X11" and "Expat" after the well-known FOSS projects that respectively adopted them.
The main difference between the two is that the X11 variant concludes with a paragraph forbidding use of the copyright holder's names in advertising or other promotion. The Expat variant does not include this language.
The full license text found in Software::License::MIT's source does not include this source, thus marking it as an Expat variant -- which doesn't agree with the X11 claim of its output. Thus this issue.
The fix would involve one of these:
Add the X11-variant concluding paragraph to the license text in Software::License::MIT.
Remove "(X11)" from Software::License::MIT's source. (My recommendation, for simplicity's sake.)
Replace "(X11)" with "(Expat)" in Software::License::MIT's source.
(One could also make two new submodules under Software::License::MIT, one for each variant, and treat the root module as an alias to one or the other, I suppose.)
Would be pleased to submit a pull request out of any of these. :)
The text was updated successfully, but these errors were encountered: