-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor convert_input.R
to Optimise Workflow
#3307
Comments
13 tasks
Sweetdevil144
added a commit
to Sweetdevil144/pecan
that referenced
this issue
Jun 24, 2024
This is an example demonstration of how we may proceed with Refactor `convert_input.R` to Optimise Workflow PecanProject#3307 Signed-off-by: Abhinav Pandey <[email protected]>
13 tasks
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tasks
PEcAn.DB::db.query
to fetch required data at once and make further checks on that basis.DB
every time we need the required information--> Chris in Slack Link
PEcAn.DB
Low Priority Tasks
These may be decided after discussion with
PEcAn
admins. This can be ignored for now, but it can also be tackled.variable out-of-scope
errorsdb.site.lat.lon
function completly and replace it withquery.site(params)['lat','lon']
Suggestion
Maybe we can try this for a better lead
convert_input
anddo_conversions
into several smaller functions. Once this is done, many other steps would become clear to us as for where to optimise the file.convert_input
we have} else if (ensemble > 1) {
where ensemble was previously declared to be of typebool
.WARN
types which shouldn't have been occuring?Context
The proposed changes are part of the GSoC project aimed at optimizing the
PEcAn
workflow. Currently, the workflow involves multiple database lookups and queries, which can lead to performance Issues.Possible Implementation
TBD or as mentioned in above task points.
The text was updated successfully, but these errors were encountered: