Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation passed to Expectations inconsistently #4

Open
scotthellman opened this issue May 28, 2015 · 0 comments
Open

Validation passed to Expectations inconsistently #4

scotthellman opened this issue May 28, 2015 · 0 comments

Comments

@scotthellman
Copy link
Contributor

Most expectations take a validation upon construction, but http expectations take a validation through their validate method, and ssh expectations take validations at both times. For consistency and to ensure that we don't report two different expectations as being the same (eg to pagerduty), we need to have our expectations all using the same pattern.

Passing in a validation at construction seems like the best option, for the above-mentioned pagerduty reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant