Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the validation in the Result object #25

Open
scotthellman opened this issue May 24, 2017 · 0 comments
Open

Don't include the validation in the Result object #25

scotthellman opened this issue May 24, 2017 · 0 comments

Comments

@scotthellman
Copy link
Contributor

We currently store the Validation in the corresponding Result. Because we use multiprocessing when running Alarmageddon, all objects in the Result must be pickleable.

As of right now, no Publishers take strong advantage of the fact that the whole Validation is available when publishing. PagerDutyPublisher does the most with it, in that it creates a string of the Validation's __dict__.

To provide users with more freedom in how they create their own Validations, we should not store the whole validation in the result, and instead just store the information needed by our Publishers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant