Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasteful loop in now() #157

Open
ghost opened this issue Apr 12, 2021 · 0 comments
Open

wasteful loop in now() #157

ghost opened this issue Apr 12, 2021 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 12, 2021

In Time.cpp, the loop at the beginning of now() is wasteful. It could be replaced with:

uint32_t n_secs = (millis() - prevMillis)/1000U;
sysTime += n_secs;
prevMillis += n_secs * 1000U;

Also, the nearby comment about subtracting unsigned values is wrong. Assuming the expression A-B, it's not the absolute value that is the same, it's that the distance from B towards A correctly accounts for overflow when A < B.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants