Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeTool overrides xlim setting #113

Open
andreasf-ki opened this issue Sep 3, 2021 · 1 comment
Open

RangeTool overrides xlim setting #113

andreasf-ki opened this issue Sep 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@andreasf-ki
Copy link

andreasf-ki commented Sep 3, 2021

Hi there.

Observation:
When using "xlim" together with "rangetool = True", the "xlim" values are ignored and the rangetool overrides w 75%-100% default x-range.

Issue:
Depending on the use case and / or the data shape on y-axis (especially in the absence of y-axis autoscale #101), this leads to unintuitive bahaviour and awkward looking initial plots.

Proposal:
Carry the xlim values forward to "__initialize_rangetool(..., xlim)" in plot.py and use this to determine initial range in
start_index = int(0.75 * len(source["__x__values"]))
p.x_range = Range1d(source["__x__values"][start_index], source["__x__values"][-1]) .

Any thoughts highly appreciated.

@PatrikHlobil
Copy link
Owner

Hi @andreasf-ki,

I attach a bug label to this issue. Thanks for reporting, I hope that we can rapidly fix the bug,

best Patrik

@PatrikHlobil PatrikHlobil added the bug Something isn't working label Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants