Bleeding Sometimes Uses Incorrect Crit Chance for Dot Multi and Perfect Agony

[chrstophr-wltrs]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

As an ailment, bleeding has some limited interactions with critical strikes. While Path of Exile does not specifically account for this increased damage in the tooltip, PoB does factor this in when calculating full DPS for another ailment: poison.

Path of Building should use the same calculations for bleeding as it does for poison for calculating chance to bleed with Perfect Agony or for effective DoT multiplier for the portion of instances created by critical strikes.

What is the value from the calculation in Path of Building?

In certain specific circumstances, the critical strike chance for bleeding is incorrect.

I strongly suspect that the issue might be related to attack accuracy, because changing the character's level (ie the evasion of enemies) has a big impact on how inaccurate the bleeding crit chance is. If the character's chance to hit is below a certain threshold, then the calculations correctly use the 'Effective Crit Chance' for determining the crit chance for bleeding.

There are 2 different contexts where crit chance matters for bleeding, and they both have problems, but at different thresholds. The following estimates use the example build, which has 1100% increased critical strike chance in the custom configuration.

Normal: the (portion of instances created by crits) for effective DoT Multi is incorrect when the Hit Chance >= 67%

Perfect Agony: the (chance from crits) factor of the 'Chance to Bleed' calculation is incorrect when the Hit Chance >= 97%

This problem also does occur without any custom modifiers, that just seemed the simplest way to reproduce the issue.

How to reproduce the issue

1. Set the character's level to '1'
2. Select 'Viper Strike' as main skill
3. Equip a vanilla 'Dragoon Sword' as mainhand weapon
4. Add 1100% increased critical strike chance to the custom configuration
5. Under the 'Bleed' section in the 'Calcs' tab, hover over the 'MH Eff. DoT Multi' value
6. Note the value of (portion of instances created by crits) as compared to the character's 'MH Crit Chance'
7. Add Perfect Agony to the custom configuration
8. Back under Calcs > Bleeding, hover over 'Chance to Bleed'
9. Note the value of (chance from crits) as compared to the character's 'MH Crit Chance'

Character build code

eNqtW21z4jgS_jz8ChdXd7VbtwFsAwm5ZK8ISSapSmaykMzefppSbAHeCIux5STs1vz365ZkMAwyNmamimCrn36T1Opum7P_vs-Y9UqjOODhed1utOoWDT3uB-HkvP70eH10Uv_vr7WzByKmn8cXScBw5NfahzP53WL0lTLA1S1BogkVX1JO7lfgNCehmFIe3pM_efSR--f1TzykdeuZhH4g0iuPkTj-RGb0vD7yAFy3SOzR0B-s7mvCKYmIJ2h0h1L7ieD33IfRMWExDM9IEI6490LFx4gnc6nVa0DfFNHt_cPn4WNGpyDM6gQmfTh7YGRBo5Egworh47zeB8-QCb0kM_gEboQlwMrt9Botp3Vy3Do5Oe50681c8EUSxWI_DqM5pf4SZDc6JsKHiF6Nx9QTwSsdRIEYTEnorcQdOybgNmK74Zzk0d8nTARzFtCoiGo3Pwjo9Uy0j1wQdvkwWpJ23JNGx7XdVteFz3Y-joslrmWivGDg0awEu9Vr9ByUcey2ekYrfg_E9Adst33SaHe6XafV6jpOLw97OwkDQfcw7YEHMQ-zwHYXpLrtnt1ydqHWF13H6TSO261uO0_RH-XZYF2jB1ba3c6x7e6agzUbj08abrflOG7vuNUzyh0kjEFUySKNEzikMY1eiQjWlTTSD_jsOQg35ty2u42Tnt1xW27LMVp0T0Iy4LHIeCKP9IFGELXEGmIXYEQ9DoFuTUingJDtUKO0u2BMi1OWMkQDymqznx1Xo6J0pRnvp9AQ9lcxyhFPWEFKsYqrjpHqkr4XoBrSb2uEZsrbUBSS-sqFPKJ3WSHDwdXNwyoW9Bq27bqtVrvndG3bGLmmizjwCLsn78EsmcHp8Uhe6EpgN2dZTaYihDhigrrGU-06iGh51IAzfw_UlPC4POwekpsbSJv6npdAErRYHQe5-6yA3yDJ8E6R9jb0im3epzCSUTiTm3RzAUPYUpgMPTNaELESoTdm9jjKFzWhoZa3KGbOHaXe9CP4d0gELRa6V6s6361IW8itSLjFrZ2CgBJOQqDBSY1eHqikm65CGk0Wo2lAmV-OOlVsQOYFoiW6OYsu5O51caVWTBZa0iW_k8gvdqaU1emVxNmobHfz3aXIiy1MClkvAHy6kcW3zLUI_xMrEVYO1o9mPIkKTrgiLmRAeqCoZHhI_cQrdoItC6oLBkVlUTOWKNCTsVLQvhDEe7nk_qSw06SQUoh1_UbJfA4xBFdDUQZ4VkISHmRSmaNuAerPsJQL7Wg8VosLWFEXFrBMFIpL2YAUtwUP-xLGrMgLi1hO6D0EixkcArJpcM8zfQPj5EDdVaiIkoTrpZ15v_E30HyK3aC4HDUkRatEyKhKRMO_FoX5r5EXEnAV-pBgwVYoLGMTsU3MYzCDQBrHl0QQy9dZ9BcSBSQUjuxUxZRE3vQOpv6aMPYMkeC8nr2LVxtAO53bs6bsxuG329mcR8Ki7_jngURikfbHJKG8A3xiEYSyiIaww1jdGk35W99_RSseOWfxsqlG5nMa-ms8HiNKLZIGEQ-VkDbihTUjsYAzS63KGJXONPNufXSjFXJQAJKbkxPXRROx3iLRor9OGAaglwBZmZ6i09HtQsUJxX44exreyS8fpkLM49Nm8-3trTEnYsrH9B2OoYbHZ805gEDho_glYOwI2Tb78O9i0pf_JKNmyulMtRHjprrCvRgFoLOayyYaKr2OnsAvn7igMY7hzfTibISiYiuGifhIZ_HFAvbPNaYNG10J7UqkHlGhFkMWc14XUUJx9sckYXj_t4SwAGcWKrXM7TvVjA15NFsWUMALphbjvGL5uJij7_t3d2qkz4TmhvLSeVbzqTWyAj-dY31Ttlr7K7UHhHmxVDwIPZb4UEro2KKnkZFn1Ax7y1gE-KlJG3yWYj6cgTaa-CPjz4Q5KUR3nNHyCZ3hOringviwr5q3Akxooh1NyQ6-fQnmuFej4EUebXLbIGbtvlwTP9z9lnWyvkCiS-Xv-pp6dqrehoEeT0I1pSGZ6e0ipVhajF5iSmG9vLTf5RJTiwi_SidLittwngjJ8Lw-C2Lv63MyHmOXG0wBrti5v7q-vho83n650vEnC5Hmfg2T2TN2cNXf1SkxojI_suLkOVZfUWP6JhW5BFcHLEa7GCPzmC4jg1wkWnMGuBxukgpK37Q9uZ3XisDM6eqdRhDIJpBYe1FAjXotx3copQRi0o3x2sQNG81mRiqLG0AYVEWBwVOys2_mgn12ozk4mIOFI4Awo2Q9usMTAsMErNZgHHh41OVPOQYVRZXjl2XjwjjfOgU185AdeBMDNWgGq862Ca1Hc7wqO_hGr6pRM_ySesRouxo0g5d1Jg_BTSYuS6ocTp_0UwHYNP2AYbponNkrRpckZoafxZRG-rQ3cbqHGJWS5G6cKHhOhHkbZyhyfCW7XgYP4ZgZqjo7BhtwLCcSrXU7DA7N0phZqS6BMZDlQVXpYPSfLkRypkDX4Ab3q9EcJ6RtCIP9ejhnk8j423_lga-KUcN22SDLCxiQyFVnIyvs6mw2S-7qHK8hF34xzrceNcOfRIBZzRYuKnspxAQ3VTUOuLeqcXiEvFMkEd2bwXAzE1lhh_k5yLJM3ApOR_Mih64e9-agaty94bIE3xst4z-kxBQsyD0AljQ5-0Mk4SU4Q-TsjYKspFrbA8nKulK81FG41dLSHNUG149-8mKAItnBCM7ym5xssRinZRvphhKGrwFwVo3hD4-4qjDDVngyJ6Gfsvu8LUdfzUNB73ERA0_ZO7nEjntVH4Z0ttjCyKzXWTOt6mRXBess3fKB8hDr5b84n_1xXj9yT7rqQtf4rq7rIem-DGDqIrnkUlFI-D9EtdXzxDNZGetGA35f9hnMPJKYqifhv1My56FEYC2vykngkW0LDKGyFotTa9gfXtU-gRFIULuMyISDj0ZvPPJrg4iMBfVPLeRfe4joOHg_tfDlq5yLEVS2BS50C-PUclo13bs5tT4ewf-adNiQfju1jp0aFD8s8AIctWt_CzKJT5-xbPhlrp8S_EJk-fYLUdv9u9P6J752Bo6xBLc8Al6xZKEBm84C02A9yvodqu8hCSfUivATn6V1nLr2kO4aoUtWztO9iPO6JnPWHfn06fa3p6vaUzgJ2L_A__F_YuuGQAIWLmqPSfQtgXKFWv1Zwqio6XbgqQWus9yGbTdaq3uDJIKJFTVVllPfWo44Gd847jbf_EnfIGOh0eIrSVPv739LC0_RwO___snuHjntn9E3l_RdUFTegi1l3YYCkMEEl5RmBhW4QBd__1vbfmp_t1vgXzi7I0pgp1iql2INNKXukViqLjSycdZ0-snptI7cTuvnsowZ5DEb1rmtI2CE1s1UNLMw2dH0M8hadtJjalNrrxmJp5z0kUxOrfQpX-0PSK43NYwtn1shF5YPUdkCD0fEUjGk2KrLI3F2k7i7Sdq7STq7Sbq7SY637iNsT5oi1XrfkoEXoUSfPTw_De8wtKpmGKyMVzzOcUg1lZv5ACXEslcQexfkgsNBY_WfF3GMMyvjk9UpIfOCMrGJd0rgZfpruXtYCbGbzDdFt_dhVMF8zcM5AI_tBnUPYFD3AAbtxWObQXaZxbVtdboH8IhzKGvKrLcbCge3qOSPLZutW1kDpzSHyiLdQ_m_c4DFYB9ge9gH0KNdciUcKsQ4VXdk-wAOLH9mHCzEulXtdypu4XIK-AtLtTurrEGVW1ThsH1jdypz6B5qWu1DxZjyS7O6H9uV57JzmEVVxnhV8x0gEroHCChuxU3Zroi3D-P_vU_K0ou2XRqxTxZV0audqrH6QNPSPlRwOVhevXcJVQI3xNaSUzk0OYeZg4OdFIco-Nr72VTW-dXP-AMlG53KilQ_4rplg0HV4PGjQNXzSd-Ikr1s-UIUD8fBRHe11YXua0vQ8s5aHyj7IpSXxILP7rkfr16csjdakmm7URK8UN0Mrv3jgUb4wMTqT3i4SO18YMSjU858GmkRFB8J6J_xpm9aHbdaOwDr76xnkDtw2V_zppiOGTOagsdH2O-Of3gPzChDv0fPGZONuqxZOZI8Lp9pFBYVB5OAfR7LZ5MAkw9YC8Bmy58m429ZaUR9KXOAb-GNKBtnmHR22JmGjiXA2QFYvv2QIrpFpmtzit3lml-uX_WcSF79Wjtrbv4U___qD1L6

[chrstophr-wltrs]

Rewrote issue to give extra details regarding the interaction between accuracy and the incorrect calculation, as well as clarifying that the problem isn't specific to Perfect Agony.

[Regisle]

Its due to us increase the chance being from a crit due to "stack potential", which is fishing for a higher bleed, we do that for hits here and for crits here

This means the more bleeds you can apply the more weighted towards a crit it becomes, without changing your crit chance, a stack potential of around one, has the same bleed crit chance due to all bleeds always being "average"

The screenshot you have is a stack potential of 1.49, and if you increase it further, to say 1782 stacks, it increases the chance its from a crit further

Its very possible the math is wrong, as the effect doesnt seem strong enough imo (I would assume if you could apply 1800 bleeds with 70% crit chance, the chance the strongest bleed is not from a crit is 6.58*10^-940 which is 0), But I think we are only making a subtle change and might revisit this in future.

[chrstophr-wltrs]

Interesting! So I guess this is only a problem for Perfect Agony then, where it's giving incorrect feedback for "chance to bleed". Could I request that be adjusted?

[Regisle]

Ill look into it, as well as the issue I spotted

[Regisle]

Interesting! So I guess this is only a problem for Perfect Agony then, where it's giving incorrect feedback for "chance to bleed". Could I request that be adjusted?

This looks like just a display issue for perfect agony (and wrong for everything else), the actual chance to bleed is calculated using normal crit chance, which is then used to calculate damage and stack potential, which then sets the new crit chance, and then figures out the value to display, so theres clearly some issues here I will try and fix.